Skip to content

Commit 403c082

Browse files
committed
Disconnect Graph view signals in closeEvent()
The signals should be disconnected once when we close the view. tear_down() gets called also when we add new databases to the editor tab.
1 parent 9a97660 commit 403c082

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

spinetoolbox/spine_db_editor/widgets/graph_view_mixin.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1013,13 +1013,6 @@ def get_open_file_path(self, group, caption, filters):
10131013
self.qsettings.endGroup()
10141014
return file_path
10151015

1016-
def tear_down(self):
1017-
if not super().tear_down():
1018-
return False
1019-
self.db_mngr.items_added.disconnect(self._refresh_icons)
1020-
self.db_mngr.items_updated.disconnect(self._refresh_icons)
1021-
return True
1022-
10231016
def closeEvent(self, event):
10241017
"""Handle close window.
10251018
@@ -1029,6 +1022,8 @@ def closeEvent(self, event):
10291022
super().closeEvent(event)
10301023
if not event.isAccepted():
10311024
return
1025+
self.db_mngr.items_added.disconnect(self._refresh_icons)
1026+
self.db_mngr.items_updated.disconnect(self._refresh_icons)
10321027
if self.scene is not None:
10331028
self.scene.deleteLater()
10341029
# Make sure the fetch parent isn't used to remove discarded changes after we've deleted the graph scene.

0 commit comments

Comments
 (0)