Skip to content

Commit 555f427

Browse files
committed
Merge branch 'release/1.2.0'
2 parents d6aa4a3 + 1d2994f commit 555f427

File tree

4 files changed

+43
-40
lines changed

4 files changed

+43
-40
lines changed

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.1.0
1+
1.2.0

composer.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,16 @@
2222
"php": ">=7.2",
2323
"ext-json": "*",
2424
"guzzlehttp/guzzle": "^6.4",
25-
"illuminate/container": "~5.7|~6|~7",
26-
"illuminate/database": "~5.7|~6|~7",
27-
"illuminate/encryption": "~5.7|~6|~7",
28-
"illuminate/http": "~5.7|~6|~7",
29-
"illuminate/routing": "~5.7|~6|~7",
25+
"illuminate/container": "~5.8|~6|~7",
26+
"illuminate/database": "~5.8|~6|~7",
27+
"illuminate/encryption": "~5.8|~6|~7",
28+
"illuminate/http": "~5.8|~6|~7",
29+
"illuminate/routing": "~5.8|~6|~7",
3030
"nesbot/carbon": "~1.2|~2",
3131
"vlucas/phpdotenv": "^3.6|^4.0"
3232
},
3333
"require-dev": {
34-
"illuminate/auth": "~5.7|~6|~7",
34+
"illuminate/auth": "~5.8|~6|~7",
3535
"mockery/mockery": "^1.3.1",
3636
"phpunit/phpunit": "^8.4|^9.0",
3737
"psy/psysh": "^0.10",

src/Support/Model.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,8 @@ abstract class Model implements Arrayable, ArrayAccess, Jsonable, JsonSerializab
149149
*/
150150
public function __construct(array $attributes = [], Model $parentModel = null)
151151
{
152-
// All dates from API comes as epoch
153-
$this->dateFormat = 'U';
152+
// All dates from API comes as epoch with milliseconds
153+
$this->dateFormat = 'Uv';
154154
// None of this models will use timestamps, but need the date casting
155155
$this->timestamps = false;
156156

tests/Support/ModelTest.php

Lines changed: 34 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
use DateTime;
66
use GuzzleHttp\Exception\InvalidArgumentException;
7-
use Illuminate\Database\Eloquent\JsonEncodingException;
87
use Illuminate\Support\Carbon;
98
use Illuminate\Support\Facades\Date;
109
use LogicException;
@@ -779,49 +778,51 @@ public function castToDatetimeValuesProvider()
779778
$carbon = Carbon::now();
780779
$datetime = new DateTime();
781780
return [
782-
'carbon' => [
783-
'value' => $carbon,
781+
'carbon' => [
782+
'value' => $carbon,
784783
'timestampsInMilliseconds' => true,
785-
'expected' => Date::instance($carbon),
784+
'expected' => Date::instance($carbon),
786785
],
787-
'datetime' => [
788-
'value' => $datetime,
786+
'datetime' => [
787+
'value' => $datetime,
789788
'timestampsInMilliseconds' => true,
790-
'expected' => Date::parse(
791-
$datetime->format('Y-m-d H:i:s.u'), $datetime->getTimezone()
792-
),
789+
'expected' => Date::parse($datetime->format('Y-m-d H:i:s.u'), $datetime->getTimezone()),
793790
],
794-
'carbon2' => [
795-
'value' => $carbon,
791+
'carbon2' => [
792+
'value' => $carbon,
796793
'timestampsInMilliseconds' => false,
797-
'expected' => Date::instance($carbon),
794+
'expected' => Date::instance($carbon),
798795
],
799-
'datetime2' => [
800-
'value' => $datetime,
796+
'datetime2' => [
797+
'value' => $datetime,
801798
'timestampsInMilliseconds' => false,
802-
'expected' => Date::parse(
803-
$datetime->format('Y-m-d H:i:s.u'), $datetime->getTimezone()
804-
),
799+
'expected' => Date::parse($datetime->format('Y-m-d H:i:s.u'), $datetime->getTimezone()),
805800
],
806-
'timestamp' => [
807-
'value' => 1579542588,
801+
'timestamp' => [
802+
'value' => 1579542588,
808803
'timestampsInMilliseconds' => false,
809-
'expected' => Date::createFromTimestamp(1579542588),
804+
'expected' => Date::createFromTimestamp(1579542588),
810805
],
811806
'timestamp_ms' => [
812-
'value' => 1579542588123,
807+
'value' => 1579542588123,
813808
'timestampsInMilliseconds' => true,
814-
'expected' => Date::createFromTimestampMs(1579542588123),
809+
'expected' => Date::createFromTimestampMs(1579542588123),
815810
],
816-
'standard' => [
817-
'value' => '2020-02-01',
811+
'standard_ms' => [
812+
'value' => '2020-02-01',
818813
'timestampsInMilliseconds' => true,
819-
'expected' => Date::instance(Carbon::createFromFormat('Y-m-d', '2020-02-01')->startOfDay()),
814+
'expected' => Date::instance(
815+
Carbon::createFromFormat('Y-m-d', '2020-02-01')
816+
->startOfDay()
817+
),
820818
],
821-
'standard' => [
822-
'value' => '2020-02-01',
819+
'standard' => [
820+
'value' => '2020-02-01',
823821
'timestampsInMilliseconds' => false,
824-
'expected' => Date::instance(Carbon::createFromFormat('Y-m-d', '2020-02-01')->startOfDay()),
822+
'expected' => Date::instance(
823+
Carbon::createFromFormat('Y-m-d', '2020-02-01')
824+
->startOfDay()
825+
),
825826
],
826827
];
827828
}
@@ -833,9 +834,11 @@ public function castToDatetimeValuesProvider()
833834
public function it_casts_to_datetime_from_various_values($value, $timestampInMilliseconds, $expected)
834835
{
835836
$model = new Model();
836-
$model->setRawAttributes([
837-
'datetime_value' => $value
838-
]);
837+
$model->setRawAttributes(
838+
[
839+
'datetime_value' => $value,
840+
]
841+
);
839842

840843
$reflection = new ReflectionObject($model);
841844

0 commit comments

Comments
 (0)