Merge pull request #24 from ezimanyi/reproducible-proto

feat(stats): Ensure reproducible proto compilation

Author: ezimanyi

.github/workflows/ci.yml

@@ -0,0 +1,16 @@
+name: Stats CI
+
+on:
+  pull_request:
+  push:
+    branches:
+      - master
+
+jobs:
+  build:
+    if: startsWith(github.repository, 'spinnaker/')
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Ensure autogenerated protos match checked-in protos
+        run: make checkproto

Dockerfile

@@ -3,8 +3,6 @@ FROM mirror.gcr.io/library/golang as builder
 ADD . /workspace
 WORKDIR /workspace
 
-RUN ./proto/regen-protos.sh
-
 ENV GOPROXY=https://proxy.golang.org
 ENV GO111MODULE=on
 ENV CGO_ENABLED=0

Makefile

@@ -0,0 +1,10 @@
+protobuilder:
+	docker build -q -t stats-protobuilder:latest build/protoc/
+
+proto_command = docker run --rm -v $(abspath proto/stats):/output/go stats-protobuilder:latest
+
+proto: protobuilder
+	$(proto_command) update
+
+checkproto: protobuilder
+	$(proto_command) check

build/protoc/Dockerfile

@@ -0,0 +1,33 @@
+FROM alpine:3.12.0 as curl
+RUN apk add --no-cache curl unzip
+
+FROM curl as protoc
+ARG PROTOC_VERSION=3.9.0
+RUN curl -vLo protoc.zip https://github.com/protocolbuffers/protobuf/releases/download/v${PROTOC_VERSION}/protoc-${PROTOC_VERSION}-linux-x86_64.zip \
+ && unzip protoc.zip
+
+FROM curl as protoc-gen-go
+ARG PROTOC_GEN_GO_TAG=v1.23.0
+RUN curl -L https://github.com/protocolbuffers/protobuf-go/releases/download/$PROTOC_GEN_GO_TAG/protoc-gen-go.$PROTOC_GEN_GO_TAG.linux.amd64.tar.gz \
+  | tar -xz
+
+FROM golang:1.14.4-buster as protoc-gen-go-json
+ARG PROTOC_GEN_GO_JSON_TAG=069933b8c8344593ed8905d46d59c6647c886f47
+RUN go get -d github.com/mitchellh/protoc-gen-go-json \
+ && git -C "$(go env GOPATH)"/src/github.com/mitchellh/protoc-gen-go-json checkout $PROTOC_GEN_GO_JSON_TAG \
+ && go install github.com/mitchellh/protoc-gen-go-json
+
+FROM curl as kork
+ARG KORK_VERSION=7.45.9
+RUN curl -L https://github.com/spinnaker/kork/archive/v$KORK_VERSION.tar.gz | tar -xz \
+  && mv kork-$KORK_VERSION kork
+
+FROM debian:buster-slim
+COPY --from=protoc /bin/protoc /usr/local/bin/protoc
+COPY --from=protoc /include/google /usr/local/include/google
+COPY --from=protoc-gen-go /protoc-gen-go /usr/local/bin/protoc-gen-go
+COPY --from=protoc-gen-go-json /go/bin/protoc-gen-go-json /bin/
+COPY --from=kork /kork/kork-proto/src/main/proto/stats/ /proto/
+RUN mkdir -p /output /staging/go
+COPY genproto.sh .
+ENTRYPOINT ["./genproto.sh"]

build/protoc/genproto.sh

@@ -0,0 +1,42 @@
+#!/bin/sh
+set -e
+
+PROTOC_FLAGS=""
+
+gen_proto() {
+  output_dir=$1
+  find /proto -name *.proto | sort | xargs protoc \
+    $PROTOC_FLAGS \
+    --proto_path=/proto \
+    --go_out=paths=source_relative:$1/go \
+    --go-json_out=$1/go
+}
+
+update_proto() {
+  gen_proto /staging
+  rm -rf /output/go/*
+  cp -r /staging/go/* /output/go/
+}
+
+check_proto() {
+  gen_proto /staging
+  if ! diff -r /staging /output; then
+    echo "Protocol buffer compilation out of date. Please run 'make proto' and commit the changes."
+    echo "To help with debugging, the difference between the committed and generated code is printed above."
+    exit 1
+  fi
+}
+
+command=$1
+case $command in
+  update)
+    update_proto
+    ;;
+  check)
+    check_proto
+    ;;
+  *)
+    echo "Unrecognized command: $command"
+    exit 2
+    ;;
+esac