Skip to content

Commit 07d4e8b

Browse files
committed
fix: always enable /bigobj on Windows
1 parent c7da3b8 commit 07d4e8b

2 files changed

Lines changed: 1 addition & 4 deletions

File tree

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ if( "${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU" )
173173
endif()
174174
elseif( "${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC" )
175175
### Disable unnecessary warnings on Windows, such as C4996 and C4267, C4244
176-
set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DNOMINMAX /utf-8 /wd4018 /wd4244 /wd4267 /wd4661 /wd4996" )
176+
set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DNOMINMAX /bigobj /utf-8 /wd4018 /wd4244 /wd4267 /wd4661 /wd4996" )
177177
endif()
178178
###
179179
message( STATUS ">> We are on the platform: ${PLATFORM_NAME}" )

core/CMake/CompilerFlags.cmake

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,6 @@ elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC")
4848
MESSAGE( STATUS ">> Chose compiler: MSVC" )
4949
### Compiler Flags
5050
set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DNOMINMAX" )
51-
if (CMAKE_BUILD_TYPE MATCHES "[dD]ebug")
52-
set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -bigobj" )
53-
endif()
5451
######################################################################
5552

5653
######## Intel Compiler - icc ########################################

0 commit comments

Comments
 (0)