Skip to content

Redis URL configuration overridden by undocumented env vars #861

Open
@jordan-lantz

Description

@jordan-lantz

https://github.com/splitio/javascript-client/blob/development/src/settings/storage/node.js#L25-L45

The use of the REDIS_* env vars is not mentioned on the Node.js SDK. Guess what I had named the env vars that my app was using for its own Redis connection 😢 Arguably this logic should be inverted, so the env vars would not override the config, or update their names to be less likely to conflict with existing env vars (e.g. SPLIT_REDIS_URL)

Also it would be really nice if enabling debug logging included some logging from the Redis client, or update the docs to suggest setting export DEBUG=ioredis:* to troubleshoot redis issues

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions