Skip to content

Commit 2a8ca52

Browse files
chore: updating integeration tests docker env[run-int-tests]
1 parent 7efd39f commit 2a8ca52

File tree

4 files changed

+38
-5
lines changed

4 files changed

+38
-5
lines changed

integration_tests/.env

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ SCHEDULER_CONFIG_FILE_ABSOLUTE_PATH=
55
TRAPS_CONFIG_FILE_ABSOLUTE_PATH=
66
INVENTORY_FILE_ABSOLUTE_PATH=
77
COREFILE_ABS_PATH=
8+
DISCOVERY_CONFIG_FILE_ABSOLUTE_PATH=
89
COREDNS_ADDRESS=172.28.0.255
910
COREDNS_ADDRESS_IPv6=fd02:0:0:0:7fff:ffff:ffff:ffff
1011
SC4SNMP_VERSION=latest
@@ -35,6 +36,11 @@ SPLUNK_HEC_PATH=/services/collector
3536
SPLUNK_AGGREGATE_TRAPS_EVENTS=false
3637
IGNORE_EMPTY_VARBINDS=false
3738

39+
# Discovery
40+
DISCOVERY_ENABLE=true
41+
DISCOVERY_LOG_LEVEL=INFO
42+
DISCOVERY_PATH=
43+
3844
# Workers configration
3945
WALK_RETRY_MAX_INTERVAL=180
4046
WALK_MAX_RETRIES=5
@@ -75,6 +81,15 @@ WORKER_TRAP_MEMORY_LIMIT=500M
7581
WORKER_TRAP_CPU_RESERVATIONS=0.5
7682
WORKER_TRAP_MEMORY_RESERVATIONS=250M
7783

84+
# Worker Discovery
85+
WORKER_DISCOVERY_CONCURRENCY=4
86+
PREFETCH_DISCOVERY_COUNT=30
87+
WORKER_DISCOVERY_REPLICAS=1
88+
WORKER_DISCOVERY_CPU_LIMIT=1
89+
WORKER_DISCOVERY_MEMORY_LIMIT=500M
90+
WORKER_DISCOVERY_CPU_RESERVATIONS=0.5
91+
WORKER_DISCOVERY_MEMORY_RESERVATIONS=250M
92+
7893
# Inventory configuration
7994
INVENTORY_LOG_LEVEL=INFO
8095
CHAIN_OF_TASKS_EXPIRY_TIME=500

integration_tests/automatic_setup_compose.sh

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,32 +104,40 @@ cp ../docker_compose/* .
104104
SCHEDULER_CONFIG_FILE="scheduler-config.yaml"
105105
TRAPS_CONFIG_FILE="traps-config.yaml"
106106
INVENTORY_FILE="inventory-tests.csv"
107+
DISCOVERY_CONFIG_FILE="discovery-config.yaml"
107108
COREFILE="Corefile"
109+
DISCOVERY_FOLDER="discovery"
108110

109111
# Get the absolute paths of the files
110112
SCHEDULER_CONFIG_FILE_ABSOLUTE_PATH=$(realpath "$SCHEDULER_CONFIG_FILE")
111113
TRAPS_CONFIG_FILE_ABSOLUTE_PATH=$(realpath "$TRAPS_CONFIG_FILE")
114+
DISCOVERY_CONFIG_FILE_ABSOLUTE_PATH=$(realpath "$DISCOVERY_CONFIG_FILE")
112115
INVENTORY_FILE_ABSOLUTE_PATH=$(realpath "$INVENTORY_FILE")
113116
COREFILE_ABS_PATH=$(realpath "$COREFILE")
114117
SPLUNK_HEC_HOST=$(hostname -I | cut -d " " -f1)
115118
SPLUNK_HEC_TOKEN=$(cat hec_token)
119+
DISCOVERY_PATH=$(realpath "$DISCOVERY_FOLDER")
116120

117121
# Temporary file to store the updated .env content
118122
TEMP_ENV_FILE=".env.tmp"
119123

120124
# Update or add the variables in the .env file
121125
awk -v scheduler_path="$SCHEDULER_CONFIG_FILE_ABSOLUTE_PATH" \
122126
-v traps_path="$TRAPS_CONFIG_FILE_ABSOLUTE_PATH" \
127+
-v discovery_config_path="$DISCOVERY_CONFIG_FILE_ABSOLUTE_PATH" \
123128
-v inventory_path="$INVENTORY_FILE_ABSOLUTE_PATH" \
124129
-v corefile_path="$COREFILE_ABS_PATH" \
130+
-v discovery_path="$DISCOVERY_PATH" \
125131
-v splunk_hec_host="$SPLUNK_HEC_HOST" \
126132
-v splunk_hec_token="$SPLUNK_HEC_TOKEN" \
127133
'
128134
BEGIN {
129135
updated["SCHEDULER_CONFIG_FILE_ABSOLUTE_PATH"] = 0;
130-
updated["TRAPS_CONFIG_FILE_ABSOLUTE_PATH"] = 0;
136+
updated["TRAPS_CONFIG_FILE_ABSOLUTE_PATH"] = 0
137+
updated["DICOVERY_CONFIG_FILE_ABSOLUTE_PATH"] = 0;
131138
updated["INVENTORY_FILE_ABSOLUTE_PATH"] = 0;
132139
updated["COREFILE_ABS_PATH"] = 0;
140+
updated["DISCOVERY_PATH"] = 0;
133141
updated["SPLUNK_HEC_HOST"] = 0;
134142
updated["SPLUNK_HEC_TOKEN"] = 0;
135143
}
@@ -140,12 +148,18 @@ awk -v scheduler_path="$SCHEDULER_CONFIG_FILE_ABSOLUTE_PATH" \
140148
} else if ($1 == "TRAPS_CONFIG_FILE_ABSOLUTE_PATH=") {
141149
print "TRAPS_CONFIG_FILE_ABSOLUTE_PATH=" traps_path;
142150
updated["TRAPS_CONFIG_FILE_ABSOLUTE_PATH"] = 1;
151+
} else if ($1 == "DISCOVERY_CONFIG_FILE_ABSOLUTE_PATH=") {
152+
print "DISCOVERY_CONFIG_FILE_ABSOLUTE_PATH=" discovery_config_path;
153+
updated["DISCOVERY_CONFIG_FILE_ABSOLUTE_PATH"] = 1;
143154
} else if ($1 == "INVENTORY_FILE_ABSOLUTE_PATH=") {
144155
print "INVENTORY_FILE_ABSOLUTE_PATH=" inventory_path;
145156
updated["INVENTORY_FILE_ABSOLUTE_PATH"] = 1;
146157
} else if ($1 == "COREFILE_ABS_PATH=") {
147158
print "COREFILE_ABS_PATH=" corefile_path;
148159
updated["COREFILE_ABS_PATH"] = 1;
160+
} else if ($1 == "DISCOVERY_PATH=") {
161+
print "DISCOVERY_PATH=" discovery_path;
162+
updated["DISCOVERY_PATH"] = 1;
149163
} else if ($1 == "SPLUNK_HEC_HOST=") {
150164
print "SPLUNK_HEC_HOST=" splunk_hec_host;
151165
updated["SPLUNK_HEC_HOST"] = 1;
@@ -163,12 +177,18 @@ awk -v scheduler_path="$SCHEDULER_CONFIG_FILE_ABSOLUTE_PATH" \
163177
if (updated["TRAPS_CONFIG_FILE_ABSOLUTE_PATH"] == 0) {
164178
print "TRAPS_CONFIG_FILE_ABSOLUTE_PATH=" traps_path;
165179
}
180+
if (updated["DISCOVERY_CONFIG_FILE_ABSOLUTE_PATH"] == 0) {
181+
print "DISCOVERY_CONFIG_FILE_ABSOLUTE_PATH=" discovery_config_path;
182+
}
166183
if (updated["INVENTORY_FILE_ABSOLUTE_PATH"] == 0) {
167184
print "INVENTORY_FILE_ABSOLUTE_PATH=" inventory_path;
168185
}
169186
if (updated["COREFILE_ABS_PATH"] == 0) {
170187
print "COREFILE_ABS_PATH=" corefile_path;
171188
}
189+
if (updated["DISCOVERY_PATH"] == 0) {
190+
print "DISCOVERY_PATH=" discovery_path;
191+
}
172192
if (updated["SPLUNK_HEC_HOST"] == 0) {
173193
print "SPLUNK_HEC_HOST=" splunk_hec_host;
174194
}

integration_tests/discovery-config.yaml

Whitespace-only changes.

splunk_connect_for_snmp/discovery/discovery_manager.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -95,10 +95,8 @@ def discover_snmp_devices_details(
9595
logger.info(
9696
f"SNMP device found: {result}. Device is from discovery: {discovery_record.discovery_name}"
9797
)
98-
else:
99-
logger.info(
100-
f"SNMP not enabled on the device: {ip}"
101-
)
98+
else:
99+
logger.info(f"SNMP not enabled on the device: {ip}")
102100
except Exception as e:
103101
logger.error(
104102
f"Snmp check for device {ip} generated an exception : {e}"

0 commit comments

Comments
 (0)