chore: refectoring check snmp device logic

Author: cwadhwani-splunk

splunk_connect_for_snmp/discovery/discovery_manager.py

@@ -54,10 +54,20 @@ def check_snmp_device(self, ip, discovery_record: DiscoveryRecord):
             _, value = var_binds[0]
             if isinstance(discovery_record.device_rules, list):
                 for device_rule in discovery_record.device_rules:
-                    regex_pattern = fnmatch.translate(device_rule["patterns"])
-                    if re.search(regex_pattern, value.prettyPrint(), re.IGNORECASE):
-                        group_name = device_rule["group"]
-                        break
+                    pattern = device_rule.get("patterns")
+                    if not pattern:
+                        continue
+                    regex_pattern = fnmatch.translate(pattern)
+                    try:
+                        if re.search(regex_pattern, value.prettyPrint(), re.IGNORECASE):
+                            group_name = device_rule["group"]
+                            break
+                    except Exception as e:
+                        logger.error(
+                            f"Error occurred while matching regex pattern {regex_pattern} : {e}"
+                            "continuing with next pattern."
+                        )
+                        continue
             return {
                 "key": discovery_record.discovery_name,
                 "ip": ip,