Add module-test project to recreate the problem

Fix invalid module name `org.spockframework.groovy2-compat` -> `org.spockframework.groovy2compat`
not that it really matters since `groovy2compat` does fundamentally not work with the module system.

Author: leonard84

Diff for: settings.gradle

@@ -29,19 +29,22 @@ include "spock-spring"
 include "spock-spring:spring3-test"
 include "spock-guice"
 include "spock-junit4"
-include "spock-temp"
 include "spock-testkit"
 
 if ((System.getProperty("variant") as BigDecimal ?: 2.5) != 3.0) {
   //Remove once Groovy 2.5 support is dropped
   include "spock-groovy2-compat"
+} else if (JavaVersion.current().isJava9Compatible()) {
+  // works only in Java 9+ and groovy 3+ as spock-groovy2-compat is incompatible with the module system
+  include "spock-module-test"
 }
 
 // https://issues.apache.org/jira/projects/TAP5/issues/TAP5-2588
 if (JavaVersion.current().isJava8()) {
   include "spock-tapestry"
 }
 
+
 include "spock-unitils"
 include "spock-gradle"
 

Diff for: spock-groovy2-compat/groovy2-compat.gradle

@@ -18,7 +18,7 @@ jar {
       'Implementation-Title': project.name,
       'Implementation-Version': variantLessVersion,
       'Implementation-Vendor': 'spockframework.org',
-      'Automatic-Module-Name': 'org.spockframework.groovy2-compat'
+      'Automatic-Module-Name': 'org.spockframework.groovy2compat'
     )
   }
 }

Diff for: spock-temp/temp.gradle renamed to spock-module-test/module-test.gradle

@@ -2,35 +2,35 @@ ext.displayName = "Spock Framework - Temp Specs for Core Module"
 
 apply plugin: "spock-base"
 
-//configurations {
-//  junit
-//}
-
 dependencies {
   testCompile project(":spock-core")
 
   testRuntime libs.asm
   testRuntime libs.bytebuddy
   testRuntime libs.cglib
   testRuntime libs.objenesis
-  testRuntime libs.h2database
-
-//  junit libs.junit4
 }
 
 sourceCompatibility = javaVersion
 targetCompatibility = javaVersion
 
-// necessary to make @NotYetImplemented transform work (transform that ships
-// with Groovy and statically references third-party class junit.framwork.AssertionFailedError)
-//tasks.withType(GroovyCompile) {
-//	groovyClasspath += configurations.junit
-//}
+tasks.withType(JavaCompile) {
+  sourceCompatibility = javaVersion
+  targetCompatibility = javaVersion
+  options.compilerArgs -= ['--release', '8']
+  options.encoding = 'UTF-8'
+}
+
+java {
+  // enable module path
+  modularity.inferModulePath = true
+}
+
 
 test {
   useJUnitPlatform()
   reports.junitXml.enabled = true
-  reports.html.enabled = false
+  reports.html.enabled = true
 
   testLogging.exceptionFormat = "full"
   testLogging.showExceptions = true

Diff for: spock-temp/src/test/groovy/temp/FirstSpec.groovy renamed to spock-module-test/src/test/groovy/org/acme/test/ModuleSmokeSpec.groovy

@@ -1,8 +1,8 @@
-package temp
+package org.acme.test
 
 import spock.lang.Specification
 
-class FirstSpec extends Specification{
+class ModuleSmokeSpec extends Specification{
 
   def "works"() {
     expect: true

Diff for: spock-module-test/src/test/java/module-info.java

@@ -0,0 +1,7 @@
+open module org.acme.test {
+  exports org.acme.test;
+
+  requires java.desktop;
+
+  requires org.spockframework.core;
+}

Diff for: spock-module-test/src/test/java/org/acme/test/PojoClass.java

@@ -0,0 +1,13 @@
+package org.acme.test;
+
+public class PojoClass {
+  private String id;
+
+  public String getId() {
+    return id;
+  }
+
+  public void setId(String id) {
+    this.id = id;
+  }
+}