Fix default flag with multiple set to true (#8)

Co-authored-by: Mateo Chronis <[email protected]>

Author: mateochr

cli_options/lib/cli_options/schema.ex

@@ -295,13 +295,13 @@ defmodule CliOptions.Schema do
   defp validate_default_value(opts) do
     opts = maybe_add_default_value(opts, opts[:type])
 
-    case validate_type_match(opts[:type], opts[:default]) do
+    case validate_type_match(option_type(opts), opts[:default]) do
       true ->
         {:ok, opts}
 
       false ->
         {:error,
-         ":default should be of type #{inspect(opts[:type])}, got: #{inspect(opts[:default])}"}
+         ":default should be of type #{inspect(option_type(opts))}, got: #{inspect(opts[:default])}"}
     end
   end
 
@@ -310,6 +310,12 @@ defmodule CliOptions.Schema do
   defp maybe_add_default_value(opts, _other), do: opts
 
   defp validate_type_match(_type, nil), do: true
+
+  defp validate_type_match({:list, type}, value) when is_list(value),
+    do: Enum.all?(value, &validate_type_match(type, &1))
+
+  defp validate_type_match({:list, _type}, value) when not is_list(value), do: false
+
   defp validate_type_match(:integer, value), do: is_integer(value)
   defp validate_type_match(:counter, value), do: is_integer(value)
   defp validate_type_match(:string, value), do: is_binary(value)

cli_options/test/cli_options/schema_test.exs

@@ -170,6 +170,26 @@ defmodule CliOptions.SchemaTest do
       assert_raise ArgumentError, message, fn ->
         CliOptions.Schema.new!(schema)
       end
+
+      # with multiple set and default not a list
+      schema = [foo: [type: :string, multiple: true, default: "foo"]]
+
+      message =
+        "invalid schema for :foo, :default should be of type {:list, :string}, got: \"foo\""
+
+      assert_raise ArgumentError, message, fn ->
+        CliOptions.Schema.new!(schema)
+      end
+
+      # with multiple set and default invalid type
+      schema = [foo: [type: :integer, multiple: true, default: ["foo"]]]
+
+      message =
+        "invalid schema for :foo, :default should be of type {:list, :integer}, got: [\"foo\"]"
+
+      assert_raise ArgumentError, message, fn ->
+        CliOptions.Schema.new!(schema)
+      end
     end
 
     test "with duplicate aliases" do

cli_options/test/cli_options_test.exs

@@ -297,6 +297,18 @@ defmodule CliOptionsTest do
                CliOptions.parse(["--file", "foo.ex,bar.ex"], schema)
     end
 
+    test "multiple with default set" do
+      schema = [file: [type: :string, multiple: true, default: ["foo.ex", "bar.ex"]]]
+
+      assert {:ok, {[file: ["foo.ex", "bar.ex"]], [], []}} = CliOptions.parse([], schema)
+
+      # multiple works as expected
+      assert {:ok, {[file: ["bar.ex"]], [], []}} = CliOptions.parse(["--file", "bar.ex"], schema)
+
+      assert {:ok, {[file: ["foo.ex", "bar.ex"]], [], []}} =
+               CliOptions.parse(["--file", "foo.ex", "--file", "bar.ex"], schema)
+    end
+
     test "multiple with separator set" do
       # without separator used
       schema = [project: [type: :string, short: "p", multiple: true, separator: ","]]