deps: SonarQube plugin API 11.4 compatibility (#1273)

Since SonarQube 2025.3 (commercial editions), the plugin API is version
11.4 and this removes the profiles importer/exporter

Author: gtoison

src/main/java/org/sonar/plugins/findbugs/FindbugsPlugin.java

@@ -22,9 +22,12 @@
 import java.util.Arrays;
 import java.util.stream.Collectors;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import org.sonar.api.Plugin;
 import org.sonar.api.batch.fs.FilePredicate;
 import org.sonar.api.batch.fs.FilePredicates;
+import org.sonar.api.utils.Version;
 import org.sonar.plugins.findbugs.classpath.DefaultClasspathLocator;
 import org.sonar.plugins.findbugs.language.Jsp;
 import org.sonar.plugins.findbugs.language.scala.Scala;
@@ -43,6 +46,7 @@
 import org.sonar.plugins.java.Java;
 
 public class FindbugsPlugin implements Plugin {
+    private static final Logger LOG = LoggerFactory.getLogger(FindbugsPlugin.class);
 
     protected static final String[] SUPPORTED_JVM_LANGUAGES = {
         Java.KEY,
@@ -60,9 +64,9 @@ public class FindbugsPlugin implements Plugin {
         "kt",
     };
 
-    public static FilePredicate[] getSupportedLanguagesFilePredicate(FilePredicates pred) {
+    public static FilePredicate[] getSupportedLanguagesFilePredicate(FilePredicates predicates) {
         return Arrays.stream(SUPPORTED_JVM_LANGUAGES)
-                .map(s -> pred.hasLanguage(s))
+                .map(predicates::hasLanguage)
                 .collect(Collectors.toList())
                 .toArray(new FilePredicate[SUPPORTED_JVM_LANGUAGES.length]);
     }
@@ -72,8 +76,6 @@ public void define(Context context) {
     context.addExtensions(FindbugsConfiguration.getPropertyDefinitions(context));
     context.addExtensions(Arrays.asList(
             FindbugsSensor.class,
-            FindbugsProfileExporter.class,
-            FindbugsProfileImporter.class,
             FindbugsConfiguration.class,
             FindbugsExecutor.class,
 
@@ -91,5 +93,14 @@ public void define(Context context) {
             FindSecurityBugsScalaRulesDefinition.class,
             DefaultClasspathLocator.class,
             ByteCodeResourceLocator.class));
+    
+    Version apiVersion = context.getRuntime().getApiVersion();
+    
+    if (!apiVersion.isGreaterThanOrEqual(Version.create(11, 4))) {
+      context.addExtension(FindbugsProfileExporter.class);
+      context.addExtension(FindbugsProfileImporter.class);
+    } else {
+      LOG.info("SonarQube plugin API version is {}, disabling the deprecated SpotBugs profile importer and exporter", apiVersion);
+    }
   }
 }

src/test/java/org/sonar/plugins/findbugs/FindbugsPluginTest.java

@@ -21,21 +21,30 @@
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
 
-import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.CsvSource;
 import org.sonar.api.Plugin;
 import org.sonar.api.SonarRuntime;
+import org.sonar.api.utils.Version;
 
 class FindbugsPluginTest {
 
-  @Test
-  void testGetExtensions() {
+  @ParameterizedTest
+  @CsvSource({
+    "11.3,26",
+    // We disable the profile importer and the exporter when the plugin API version is >= 11.4 (since 2025.3 commercial editions)
+    "11.4,24"
+  })
+  void testGetExtensions(String version, int expectedExtensionsCount) {
     SonarRuntime runtime = mock(SonarRuntime.class);
+    when(runtime.getApiVersion()).thenReturn(Version.parse(version));
     Plugin.Context ctx = new Plugin.Context(runtime);
 
     FindbugsPlugin plugin = new FindbugsPlugin();
     plugin.define(ctx);
 
-    assertEquals(26, ctx.getExtensions().size(), "extensions count");
+    assertEquals(expectedExtensionsCount, ctx.getExtensions().size(), "extensions count");
   }
 }