Skip to content

Conversation

@fabriziodemaria
Copy link
Member

@fabriziodemaria fabriziodemaria commented Sep 2, 2025

Sample output (note the release title will be different when running properly from a release please version):
Screenshot 2025-09-02 at 14 28 00

@@ -1,7 +1,8 @@
name: Build and Push Deployer Image
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I moved the pushing to the release-please.yml for consistency

Copy link
Contributor

@andreas-karlsson andreas-karlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Had some minor comments. Also. What's the sha in the release name? Do we need it there? I think releases are already "connected" to the state they were created from. I think we should also get the version in there?

@fabriziodemaria
Copy link
Member Author

What's the sha in the release name?

The sha in the name (assuming you refer to my screenshot) was there just in my manual test. Final release will be simply the version from release please

@fabriziodemaria fabriziodemaria merged commit 23ab190 into main Sep 3, 2025
5 checks passed
@fabriziodemaria fabriziodemaria deleted the wasm-distr branch September 3, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants