-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Resolver WASM distribution via GitHub Releases #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b1407ca to
e505ec8
Compare
f955f00 to
0e72bc9
Compare
| @@ -1,7 +1,8 @@ | |||
| name: Build and Push Deployer Image | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I moved the pushing to the release-please.yml for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Had some minor comments. Also. What's the sha in the release name? Do we need it there? I think releases are already "connected" to the state they were created from. I think we should also get the version in there?
The sha in the name (assuming you refer to my screenshot) was there just in my manual test. Final release will be simply the version from release please |
Sample output (note the release title will be different when running properly from a release please version):
