fix: wasm profile and small fixes #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreas-karlsson
commented
Sep 1, 2025
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
I think we should have this checked in as anyone using this editor will have to define these or have errors in the tooling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our build was wrongly configured, apparently the config in project toml doesn't apply. This fix brings the wasm size down from 535K to 353K (yes it "inverts" the digits 😄 ). Some other minor improvements are also included.
Edit: The PR isn't so small any longer cause I broke the path of the built wasm module that is shared between the host projects which are all ran in ci. I fixed this by introducing a more sensible and stable path
wasm/rust_guest.wasmand create a make file target for it. I also removed generated proto sources that were committed in node and go and made the ci integration tests all use make. On the upside I was wrong about the size reduction in the wasm module and it's actually even better; now at 286K.