Skip to content

Commit 4f00fa7

Browse files
nicklaslclaude
andcommitted
fix(resolver): silently drop invalid flag names instead of logging
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 392499d commit 4f00fa7

2 files changed

Lines changed: 2 additions & 10 deletions

File tree

confidence-resolver/src/lib.rs

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -833,14 +833,7 @@ impl<'a, H: Host> AccountResolver<'a, H> {
833833
let flag_names: Vec<String> = resolve_request
834834
.flags
835835
.iter()
836-
.filter(|name| {
837-
if let Err(e) = validate_flag_name(name) {
838-
H::log(&format!("WARN: {}, skipping", e));
839-
false
840-
} else {
841-
true
842-
}
843-
})
836+
.filter(|name| validate_flag_name(name).is_ok())
844837
.cloned()
845838
.collect();
846839
let flags_to_resolve = self
@@ -995,8 +988,7 @@ impl<'a, H: Host> AccountResolver<'a, H> {
995988
// ensure that all flags are present before we start sending events
996989
let mut assigned_flags: Vec<FlagToApply> = Vec::with_capacity(request.flags.len());
997990
for applied_flag in &request.flags {
998-
if let Err(e) = validate_flag_name(&applied_flag.flag) {
999-
H::log(&format!("WARN: {}, skipping", e));
991+
if validate_flag_name(&applied_flag.flag).is_err() {
1000992
continue;
1001993
}
1002994
let Some(assigned_flag) = assignments.get(&applied_flag.flag) else {
Binary file not shown.

0 commit comments

Comments
 (0)