Skip to content

Commit cf2abbd

Browse files
authored
kubernetes contrib: labels are applied to pod (#3007)
1 parent d4eb8a6 commit cf2abbd

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

luigi/contrib/kubernetes.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,8 @@ def run(self):
363363
"backoffLimit": self.backoff_limit,
364364
"template": {
365365
"metadata": {
366-
"name": self.uu_name
366+
"name": self.uu_name,
367+
"labels": {}
367368
},
368369
"spec": self.spec_schema
369370
}
@@ -376,6 +377,8 @@ def run(self):
376377
self.active_deadline_seconds
377378
# Update user labels
378379
job_json['metadata']['labels'].update(self.labels)
380+
job_json['spec']['template']['metadata']['labels'].update(self.labels)
381+
379382
# Add default restartPolicy if not specified
380383
if "restartPolicy" not in self.spec_schema:
381384
job_json["spec"]["template"]["spec"]["restartPolicy"] = "Never"

test/contrib/kubernetes_test.py

+5
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,10 @@ class FailJob(KubernetesJobTask):
7171
}]
7272
}
7373

74+
@property
75+
def labels(self):
76+
return {"dummy_label": "dummy_value"}
77+
7478

7579
@attr('contrib')
7680
class TestK8STask(unittest.TestCase):
@@ -90,6 +94,7 @@ def test_fail_job(self):
9094
job = Job(kube_api, jobs.response["items"][0])
9195
self.assertTrue("failed" in job.obj["status"])
9296
self.assertTrue(job.obj["status"]["failed"] > fail.max_retrials)
97+
self.assertTrue(job.obj['spec']['template']['metadata']['labels'] == fail.labels())
9398

9499
@mock.patch.object(KubernetesJobTask, "_KubernetesJobTask__get_job_status")
95100
@mock.patch.object(KubernetesJobTask, "signal_complete")

0 commit comments

Comments
 (0)