PHP 8.4 compatibility ?

[dertin]

Hi, @vlucas
I’m reviewing an old project that uses this dependency at its core, and I’d like to know if there are any known compatibility issues with PHP 8.4. Is there any plan to continue support? I’d be happy to help if needed.

[dertin]

Will it be necessary to apply any additional patches in version v2.2.1 ? @vlucas @FlipEverything

--- a/vendor/vlucas/spot2/lib/Config.php
+++ b/vendor/vlucas/spot2/lib/Config.php
@@ -285,4 +285,19 @@
     public function unserialize($serialized)
     {
     }
+
+    /**
+     * PHP 7.4+ serialization hook: must return an array
+     */
+    public function __serialize(): array
+    {
+        return [];
+    }
+
+    /**
+     * PHP 7.4+ unserialization hook: receives the array from __serialize()
+     */
+    public function __unserialize(array $data): void
+    {
+    }
 }
--- a/vendor/vlucas/spot2/lib/Query.php
+++ b/vendor/vlucas/spot2/lib/Query.php
@@ -407,7 +407,8 @@ class Query implements \IteratorAggregate, \Countable
             return static::$_whereOperators[$operator];
         }
 
         if (!isset(static::$_whereOperatorObjects[$operator])) {
-            static::$_whereOperatorObjects[$operator] = new static::$_whereOperators[$operator]();
+            $operatorClass = static::$_whereOperators[$operator];
+            static::$_whereOperatorObjects[$operator] = new $operatorClass();
         }
 
         return static::$_whereOperatorObjects[$operator];