Documenting why filter is not implemented

bathalh · bathalh · commit 6a6184a80a33 · 2016-02-22T12:01:20.000-06:00
diff --git a/src/main/scala/spray/json/Tription.scala b/src/main/scala/spray/json/Tription.scala
@@ -20,7 +20,7 @@ package spray.json
   *
   * Created by bathalh on 2/19/16.
   */
-abstract class Tription[+T]
+sealed abstract class Tription[+T] extends Product
 {
     def isDefined: Boolean
     def isNull: Boolean
@@ -42,6 +42,10 @@ abstract class Tription[+T]
 
     final def foreach[U](f: T => U): Unit =
         if( hasValue ) f( this.get )
+
+    // not sure whether to return Null or Undefined if the filter criteria are not met
+//    final def filter(p: T => Boolean): Tription[T] =
+//        if (!hasValue || p(this.get)) this else (Undefined/Null)
 }
 
 case class Value[+T](x: T) extends Tription[T] {

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ package spray.json`
`20`	`20`	`*`
`21`	`21`	`* Created by bathalh on 2/19/16.`
`22`	`22`	`*/`
`23`		`-abstract class Tription[+T]`
	`23`	`+sealed abstract class Tription[+T] extends Product`
`24`	`24`	`{`
`25`	`25`	`def isDefined: Boolean`
`26`	`26`	`def isNull: Boolean`
`@@ -42,6 +42,10 @@ abstract class Tription[+T]`
`42`	`42`
`43`	`43`	`final def foreach[U](f: T => U): Unit =`
`44`	`44`	`if( hasValue ) f( this.get )`
	`45`	`+`
	`46`	`+ // not sure whether to return Null or Undefined if the filter criteria are not met`
	`47`	`+// final def filter(p: T => Boolean): Tription[T] =`
	`48`	`+// if (!hasValue \|\| p(this.get)) this else (Undefined/Null)`
`45`	`49`	`}`
`46`	`50`
`47`	`51`	`case class Value[+T](x: T) extends Tription[T] {`