Merge pull request #282 from spark-solutions/feature/cleanup

3.2.0 release

Author: damianlegawiec

.rspec

@@ -1 +1,3 @@
---colour
+--color
+-r spec_helper
+-f documentation

README.md

@@ -1,40 +1,42 @@
 # Spree Gateway
 
-[![Build Status](https://api.travis-ci.org/spree/spree_gateway.png?branch=master)](https://travis-ci.org/spree/spree_gateway)
-[![Code Climate](https://codeclimate.com/github/spree/spree_gateway.png)](https://codeclimate.com/github/spree/spree_gateway)
+[![Build Status](https://api.travis-ci.org/spree/spree_gateway.svg?branch=master)](https://travis-ci.org/spree/spree_gateway)
+[![Code Climate](https://codeclimate.com/github/spree/spree_gateway.svg)](https://codeclimate.com/github/spree/spree_gateway)
 
 Community supported Spree Payment Method Gateways. It works as a wrapper for
 active_merchant gateway. Note that for some gateways you might still need to
 add another gem to your Gemfile to make it work. For example active_merchant
 require `braintree` but it doesn't include that gem on its gemspec. So you
 need to manually add it to your rails app Gemfile.
 
-These can be used with Spree >= 1.0.x (but see note below for necessary changes)
-
-http://guides.spreecommerce.com/developer/payments.html
-
 ## Installation
 
-In your Gemfile:
+1. Add this extension to your Gemfile with this line:
+
+  #### Spree >= 3.1
 
-**Spree edge**
+  ```ruby
+  gem 'spree_gateway', github: 'spree/spree_gateway'
+  ```
 
-```ruby
-gem 'spree'
-gem 'spree_gateway', github: 'spree/spree_gateway', branch: 'master'
-```
+  #### Spree 3.0 and Spree 2.x
 
-**Spree 1.3**
+  ```ruby
+  gem 'spree_gateway', github: 'spree/spree_gateway', branch: 'X-X-stable'
+  ```
 
-```ruby
-gem 'spree', '~> 1.3'
-gem 'spree_gateway', github: 'spree/spree_gateway', branch: '1-3-stable'
-```
+  The `branch` option is important: it must match the version of Spree you're using.
+  For example, use `3-0-stable` if you're using Spree `3-0-stable` or any `3.0.x` version.
 
-Then run from the command line:
+2. Install the gem using Bundler:
+  ```ruby
+  bundle install
+  ```
 
-    $ bundle install
-    $ rails g spree_gateway:install
+3. Copy & run migrations
+  ```ruby
+  bundle exec rails g spree_gateway:install
+  ```
 
 Finally, make sure to **restart your app**. Navigate to *Configuration > Payment Methods > New Payment Method* in the admin panel and you should see that a bunch of additional gateways have been added to the list.
 

spec/models/gateway/braintree_gateway_spec.rb

@@ -69,8 +69,23 @@
 
   describe 'payment profile failure' do
     before do
-      order = create(:order_with_totals, bill_address: address, ship_address: address)
-      order.update_with_updater!
+      country = Spree::Country.default
+      state   = country.states.first
+      address = create(:address,
+        firstname: 'John',
+        lastname:  'Doe',
+        address1:  '1234 My Street',
+        address2:  'Apt 1',
+        city:      'Washington DC',
+        zipcode:   '20123',
+        phone:     '(555)555-5555',
+        state:     state,
+        country:   country
+      )
+      @address = address
+
+      @order = create(:order_with_totals, bill_address: address, ship_address: address)
+      @order.update_with_updater!
 
       @credit_card = create(:credit_card,
         verification_value: '123',
@@ -82,7 +97,7 @@
     end
 
     it 'should fail creation' do
-      expect{ create(:payment, source: @credit_card, order: order, payment_method: @gateway, amount: 10.00) }.to raise_error
+      expect{ create(:payment, source: @credit_card, order: @order, payment_method: @gateway, amount: 10.00) }.to raise_error Spree::Core::GatewayError
     end
 
   end

spree_gateway.gemspec

@@ -2,7 +2,7 @@
 Gem::Specification.new do |s|
   s.platform    = Gem::Platform::RUBY
   s.name        = 'spree_gateway'
-  s.version     = '3.2.0.beta'
+  s.version     = '3.2.0'
   s.summary     = 'Additional Payment Gateways for Spree Commerce'
   s.description = s.summary