Skip to content
This repository has been archived by the owner on Feb 23, 2020. It is now read-only.
This repository has been archived by the owner on Feb 23, 2020. It is now read-only.

UpdateShipment has incomplete error message if shipment items do not match #69

Open
@MisinformedDNA

Description

The code here, verifies that received shipment items is a superset of the shipment in the order, but it does not check that the sets are equal.

So if I order product A and B and only product A gets shipped, then Spree will be told that the entire order was shipped when it was not.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions