Skip to content
This repository was archived by the owner on Apr 5, 2022. It is now read-only.
This repository was archived by the owner on Apr 5, 2022. It is now read-only.

Property mapping failure fails silently #6

@bobpardoe

Description

@bobpardoe

When PATCHing via rest and passing an invalid column name in the Json body, the save fails silently.

doMerge() in DomainObjectReader class of spring-data-rest-webmvc-2.5.2.RELEASE.jar

Has the following

 if (!mappedProperties.hasPersistentPropertyForField(fieldName)) {
                i.remove();
                continue;
}

Would it not be better for some sort of mapping exception to be raised?

Nothing is written to the console or exception raised. Just a 204 is returned (I am intentionally not returning the updated row).

This makes it impossible for the client to determine if the PATCH / PUT update was successful or not.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions