doc issue: backing app timeouts are not configureable per app

[gberche-orange]

The documentation mentions that timeouts such as api-timeout can be set for a specific app deployment

spring-cloud-app-broker/spring-cloud-app-broker-docs/src/docs/asciidoc/service-instances.adoc

Lines 53 to 54 in b6861ea

	The following table lists properties that can be set for all or specific app deployments.

spring-cloud-app-broker/spring-cloud-app-broker-docs/src/docs/asciidoc/service-instances.adoc

Lines 105 to 107 in b6861ea

	|`api-timeout`
	|The timeout value used for blocking API calls, in seconds.
	|`360`

However, the timeout seems always fetched from a singleton bean

spring-cloud-app-broker/spring-cloud-app-broker-deployer-cloudfoundry/src/main/java/org/springframework/cloud/appbroker/deployer/cloudfoundry/CloudFoundryAppDeployer.java

Line 177 in c32dd2b

.timeout(Duration.ofSeconds(this.defaultDeploymentProperties.getApiTimeout()))

spring-cloud-app-broker/spring-cloud-app-broker-autoconfigure/src/main/java/org/springframework/cloud/appbroker/autoconfigure/CloudFoundryAppDeployerAutoConfiguration.java

Lines 66 to 85 in bc75e24

	CloudFoundryDeploymentProperties cloudFoundryDeploymentProperties() {
	return new CloudFoundryDeploymentProperties();
	}
	@Bean
	@ConfigurationProperties(PROPERTY_PREFIX)
	CloudFoundryTargetProperties cloudFoundryTargetProperties() {
	return new CloudFoundryTargetProperties();
	}
	@Bean
	AppDeployer cloudFoundryAppDeployer(CloudFoundryDeploymentProperties deploymentProperties,
	CloudFoundryOperations cloudFoundryOperations,
	CloudFoundryClient cloudFoundryClient,
	CloudFoundryOperationsUtils operationsUtils,
	CloudFoundryTargetProperties targetProperties,
	ResourceLoader resourceLoader) {
	return new CloudFoundryAppDeployer(deploymentProperties, cloudFoundryOperations, cloudFoundryClient,
	operationsUtils, targetProperties, resourceLoader);
	}

[royclarkson]

@gberche-orange it appears that you worked on the api-polling-timeout support, which sets the CF deployment timeout. api-timeout in comparison only affects the Reactor timeout for the app push request (and also the app delete request). It's currently only used in those two places. Before I work on changes here, is that the value you are wanting to have configurable? I agree that the docs should reflect the actual behavior, regardless of what that behavior is.

[gberche-orange]

thanks @royclarkson for looking into this. I actually don't yet need the timeout to be configurable by app. I was rather raising the point that the doc seemed misleading, and hoped it could help other users. I've updated the issue title to remove ambiguity.

[royclarkson]

Understood, thanks! I'll fix the docs and remove the confusion.