Conditional Caching in ServerWebExchangeUtils.cacheRequestBody

[zhenchuan9r]

For some reasons we do not limit the size of request body size.
And as a usual practise we enable RetryFilter on routes.
And here comes the problem.
When we enable the RetryFilter, the RetryFilter also enable request body caching.
Thus when the clients post a large request body, the server's memory is easilly overflowed.
However, currently, we cannot config the caching strategeis in RetryFilter/AdaptCachedBodyGlobalFilter/ServerWebExchangeUtils.
We cannot even override those classes.
This is a fatal problem and we are still figuring out a workaround...

[spencergibb]

This is a well known issue with retrying requests with bodies at all. What kind of strategy would you hope for?

[zhenchuan9r]

This is a well known issue with retrying requests with bodies at all. What kind of strategy would you hope for?

I think Nginx had already made a good practise on this problem. A simple strategy would be to set a threshold on maximum in-memory cachable request body, like 10mb. If the request body is larger than the threshold, redirect the content to a temp file; if not, cache in memory. Another strategy is to disable caching when the request body is too large.