Skip to content

Multiple implementations of ResponseInterceptor fail to trigger #1006

Open
@marcdv

Description

@marcdv

Describe the bug
I have 2 implementations of ResponseInterceptor, both fail to trigger in 4.1.0. If I remove one of them, then it works.

@Component
public class AuditorGatewayResponseInterceptor implements ResponseInterceptor {

//// removed
}
@Component
public class AnotherResponseInterceptor implements ResponseInterceptor {

//removed
}

Activity

OlgaMaciaszek

OlgaMaciaszek commented on Mar 20, 2024

@OlgaMaciaszek
Collaborator

Hello @marcdv, thanks for creating an issue. Please provide a minimal, complete, verifiable example that reproduces the issue, as a link to a GitHub repo with an executable app or tests.

Please learn how to properly format code and logs.

spring-cloud-issues

spring-cloud-issues commented on Mar 27, 2024

@spring-cloud-issues

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

galaxy-sea

galaxy-sea commented on Apr 1, 2024

@galaxy-sea
Contributor

hello @marcdv , see gh-1003

marcdv

marcdv commented on Apr 8, 2024

@marcdv
Author

Please review https://github.com/marcdv/testFeign for an example

Steps to reproduce

  1. Start the server
    gradle bootrun

  2. call the API
    GET http://localhost:8080/api/test

  3. Review logs in console (note no logs)

  4. Comment out line 10 (@component) in AResponseInterceptor.java

  5. Restart the server

  6. Call the API as above

  7. Review logs (note BResponseInterceptor was called)

OlgaMaciaszek

OlgaMaciaszek commented on Apr 15, 2024

@OlgaMaciaszek
Collaborator

Thanks, @marcdv. That's actually never been supported and also the docs only show a way to provide one interceptor, so this would be an enhancement. Since this project is now in maintenance mode (suggested replacement: Spring Interface Clients), we are not planning on adding new features ourselves, but we still review small community PR. I see @galaxy-sea has submitted a PR for this, but it has breaking changes, so can only be considered for a major release and I will mark it as such, however at this point it has not been decided if there will be another major of this project.

5 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Multiple implementations of ResponseInterceptor fail to trigger · Issue #1006 · spring-cloud/spring-cloud-openfeign