Skip to content

Commit 97e5561

Browse files
committed
Merge pull request #1292 from vpavic
* pr/1292: Update copyright year of changed files Ensure Gradle tasks are configured lazily Closes gh-1292
2 parents 35e41a8 + 5c6a531 commit 97e5561

File tree

17 files changed

+25
-23
lines changed

17 files changed

+25
-23
lines changed

Diff for: initializr-generator-spring/src/test/java/io/spring/initializr/generator/spring/build/gradle/GradleProjectGenerationConfigurationTests.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ void buildDotGradleIsContributedWhenGeneratingGradleProject() {
129129
" testImplementation 'org.springframework.boot:spring-boot-starter-test'",
130130
"}",
131131
"",
132-
"test {",
132+
"tasks.named('test') {",
133133
" useJUnitPlatform()",
134134
"}"); // @formatter:on
135135
}
@@ -150,7 +150,8 @@ void junitPlatformIsConfiguredWithCompatibleVersion() {
150150
description.setPlatformVersion(Version.parse("2.2.4.RELEASE"));
151151
description.setLanguage(new JavaLanguage());
152152
ProjectStructure project = this.projectTester.generate(description);
153-
assertThat(project).textFile("build.gradle").lines().containsSequence("test {", " useJUnitPlatform()", "}");
153+
assertThat(project).textFile("build.gradle").lines().containsSequence("tasks.named('test') {",
154+
" useJUnitPlatform()", "}");
154155
}
155156

156157
@Test

Diff for: initializr-generator-spring/src/test/resources/project/gradle/annotation-processor-dependency-build.gradle.gen

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,6 @@ dependencies {
2525
testImplementation 'org.springframework.boot:spring-boot-starter-test'
2626
}
2727

28-
test {
28+
tasks.named('test') {
2929
useJUnitPlatform()
3030
}

Diff for: initializr-generator-spring/src/test/resources/project/gradle/bom-ordering-build.gradle.gen

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,6 @@ dependencyManagement {
2525
}
2626
}
2727

28-
test {
28+
tasks.named('test') {
2929
useJUnitPlatform()
3030
}

Diff for: initializr-generator-spring/src/test/resources/project/gradle/bom-property-build.gradle.gen

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,6 @@ dependencyManagement {
2727
}
2828
}
2929

30-
test {
30+
tasks.named('test') {
3131
useJUnitPlatform()
3232
}

Diff for: initializr-generator-spring/src/test/resources/project/gradle/compile-only-dependency-build.gradle.gen

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,6 @@ dependencies {
1919
testImplementation 'org.springframework.boot:spring-boot-starter-test'
2020
}
2121

22-
test {
22+
tasks.named('test') {
2323
useJUnitPlatform()
2424
}

Diff for: initializr-generator-spring/src/test/resources/project/gradle/kotlin-java11-build.gradle.gen

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,6 @@ tasks.withType(KotlinCompile) {
2929
}
3030
}
3131

32-
test {
32+
tasks.named('test') {
3333
useJUnitPlatform()
3434
}

Diff for: initializr-generator-spring/src/test/resources/project/gradle/repositories-build.gradle.gen

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@ dependencies {
2020
testImplementation 'org.springframework.boot:spring-boot-starter-test'
2121
}
2222

23-
test {
23+
tasks.named('test') {
2424
useJUnitPlatform()
2525
}

Diff for: initializr-generator-spring/src/test/resources/project/gradle/repositories-milestone-build.gradle.gen

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,6 @@ dependencies {
1818
testImplementation 'org.springframework.boot:spring-boot-starter-test'
1919
}
2020

21-
test {
21+
tasks.named('test') {
2222
useJUnitPlatform()
2323
}

Diff for: initializr-generator-spring/src/test/resources/project/gradle/version-override-build.gradle.gen

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,6 @@ dependencies {
2222
testImplementation 'org.springframework.boot:spring-boot-starter-test'
2323
}
2424

25-
test {
25+
tasks.named('test') {
2626
useJUnitPlatform()
2727
}

Diff for: initializr-generator-spring/src/test/resources/project/groovy/standard/build.gradle.gen

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,6 @@ dependencies {
1818
testImplementation 'org.springframework.boot:spring-boot-starter-test'
1919
}
2020

21-
test {
21+
tasks.named('test') {
2222
useJUnitPlatform()
2323
}

Diff for: initializr-generator-spring/src/test/resources/project/groovy/standard/war-build.gradle.gen

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@ dependencies {
2020
testImplementation 'org.springframework.boot:spring-boot-starter-test'
2121
}
2222

23-
test {
23+
tasks.named('test') {
2424
useJUnitPlatform()
2525
}

Diff for: initializr-generator-spring/src/test/resources/project/java/standard/build.gradle.gen

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,6 @@ dependencies {
1717
testImplementation 'org.springframework.boot:spring-boot-starter-test'
1818
}
1919

20-
test {
20+
tasks.named('test') {
2121
useJUnitPlatform()
2222
}

Diff for: initializr-generator-spring/src/test/resources/project/java/standard/war-build.gradle.gen

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,6 @@ dependencies {
1919
testImplementation 'org.springframework.boot:spring-boot-starter-test'
2020
}
2121

22-
test {
22+
tasks.named('test') {
2323
useJUnitPlatform()
2424
}

Diff for: initializr-generator-spring/src/test/resources/project/kotlin/standard/build.gradle.gen

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,6 @@ tasks.withType(KotlinCompile) {
2929
}
3030
}
3131

32-
test {
32+
tasks.named('test') {
3333
useJUnitPlatform()
3434
}

Diff for: initializr-generator-spring/src/test/resources/project/kotlin/standard/war-build.gradle.gen

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,6 @@ tasks.withType(KotlinCompile) {
3131
}
3232
}
3333

34-
test {
34+
tasks.named('test') {
3535
useJUnitPlatform()
3636
}

Diff for: initializr-generator/src/main/java/io/spring/initializr/generator/buildsystem/gradle/GroovyDslGradleBuildWriter.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2020 the original author or authors.
2+
* Copyright 2012-2022 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -190,7 +190,7 @@ protected void writeTasks(IndentingWriter writer, GradleTaskContainer tasks) {
190190
});
191191
tasks.values().filter((candidate) -> candidate.getType() == null).forEach((task) -> {
192192
writer.println();
193-
writer.println(task.getName() + " {");
193+
writer.println("tasks.named('" + task.getName() + "') {");
194194
writer.indented(() -> writeTaskCustomization(writer, task));
195195
writer.println("}");
196196
});

Diff for: initializr-generator/src/test/java/io/spring/initializr/generator/buildsystem/gradle/GroovyDslGradleBuildWriterTests.java

+6-5
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2021 the original author or authors.
2+
* Copyright 2012-2022 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -170,15 +170,16 @@ void gradleBuildWithTaskCustomizedWithInvocations() {
170170
task.invoke("dependsOn", "test");
171171
});
172172
List<String> lines = generateBuild(build);
173-
assertThat(lines).containsSequence("asciidoctor {", " inputs.dir snippetsDir", " dependsOn test", "}");
173+
assertThat(lines).containsSequence("tasks.named('asciidoctor') {", " inputs.dir snippetsDir",
174+
" dependsOn test", "}");
174175
}
175176

176177
@Test
177178
void gradleBuildWithTaskCustomizedWithInvocationAndNoArgument() {
178179
GradleBuild build = new GradleBuild();
179180
build.tasks().customize("test", (task) -> task.invoke("myMethod"));
180181
List<String> lines = generateBuild(build);
181-
assertThat(lines).containsSequence("test {", " myMethod()", "}");
182+
assertThat(lines).containsSequence("tasks.named('test') {", " myMethod()", "}");
182183
}
183184

184185
@Test
@@ -189,7 +190,7 @@ void gradleBuildWithTaskCustomizedWithAssignments() {
189190
task.attribute("kotlinOptions.jvmTarget", "'1.8'");
190191
});
191192
List<String> lines = generateBuild(build);
192-
assertThat(lines).containsSequence("compileKotlin {",
193+
assertThat(lines).containsSequence("tasks.named('compileKotlin') {",
193194
" kotlinOptions.freeCompilerArgs = ['-Xjsr305=strict']", " kotlinOptions.jvmTarget = '1.8'", "}");
194195
}
195196

@@ -202,7 +203,7 @@ void gradleBuildWithTaskCustomizedWithNestedCustomization() {
202203
kotlinOptions.attribute("jvmTarget", "'1.8'");
203204
}));
204205
List<String> lines = generateBuild(build);
205-
assertThat(lines).containsSequence("compileKotlin {", " kotlinOptions {",
206+
assertThat(lines).containsSequence("tasks.named('compileKotlin') {", " kotlinOptions {",
206207
" freeCompilerArgs = ['-Xjsr305=strict']", " jvmTarget = '1.8'", " }", "}");
207208
}
208209

0 commit comments

Comments
 (0)