SimpleJobLauncher parameter validation and JobExecutionListener [BATCH-2375]

[spring-projects-issues]

Sandor Nemeth opened BATCH-2375 and commented

When execution jobs with the SimpleJobLauncher, the validation of the parameters happens without regard to the set JobExecutionListeners. However the same call to the same JobParametersValidator is handled (at least regarding to the JobExecutionListener#afterJob(JobExecution jobExecution) call) properly in the AbstractJob class.

I have attached the minimal case to reproduce the scenario. Simply run mvn spring-boot:run to run the application. The expected outcome is to see at least the "after job" message in the console.

Priority is set to major, because there are business scenarios that can be affected by this behaviour (e.g. when developing a completely automatic import process where if the import fails, the process should be completely stopped (the system should not be able to start a new process in this case)).
Please redefine the priority if you think otherwise.

---

Affects: 3.0.3

Attachments:

• joblistener.zip (4.19 kB)

[fmbenhassine]

When execution jobs with the SimpleJobLauncher, the validation of the parameters happens without regard to the set JobExecutionListeners.

I do confirm, the SimpleJobLauncher validates job parameters before submitting the job to the executor, hence job listeners are not invoked when parameters are not valid.

However the same call to the same JobParametersValidator is handled (at least regarding to the JobExecutionListener#afterJob(JobExecution jobExecution) call) properly in the AbstractJob class.

Do you mean not properly? Because what I see is that AbstractJob validates parameters in a try block and calls listener.afterJob in a finally block, here is a simplified form:

try {
   jobParametersValidator.validate(execution.getJobParameters());
   // ...
   listener.beforeJob(execution);
   doExecute(execution);
} catch (Throwable t) {
   // ...
} finally {
   listener.afterJob(execution);
   // ...
}

Which means that when job parameters are invalid, listener.afterJob will be invoked while listener.beforeJob will not invoked (which can be problematic). I think parameters validation should be moved outside the try bloc to be consistent with SimpleJobLauncher.

That said, I fail to see the use case of running jobs by manually calling the execute method and not using the launcher (with all its added value like checking the last execution, creating a JobExecution instance, etc).