JobExecutionDecider not working with custom ExitStatus

[vamsigangarapu]

Bug description
When we produce custom Exit status from a tasklet and use a JobExecutionDecider to decide the flow, we get an error.

Environment
Please provide as many details as possible: Spring Batch version, Java version, which database you use if any, etc
Spring Batch Version - 4.3.8
JDK - 11

Steps to reproduce
Send a custom Exit status from a taklet and use it in the JobExecutionDecider to decide the flow.

Expected behavior
The Tasklet should produce the status completed and the JobExecutionDecider should take the ExitStatus from the step and validate the status and decide on the flow.

Minimal Complete Reproducible example

@Bean
public Step initialStep() {
    return stepBuilderFactory.get("initialStep")
            .tasklet((contribution, chunkContext) -> {
                System.out.println("INTIAL STEP");
                return RepeatStatus.FINISHED;
            }).listener(stepExecutionListener()).build();
}

@Bean
public StepExecutionListener stepExecutionListener() {
    return new MyStepExecutionListener();
}

static class MyStepExecutionListener implements StepExecutionListener {

    @Override
    public void beforeStep(StepExecution stepExecution) {
        System.out.println("MyStepExecutionListener.beforeStep");
    }

    @Override
    public ExitStatus afterStep(StepExecution stepExecution) {
        var inputFileName = stepExecution.getJobParameters().getString("inputFileName");
        System.out.println("MyStepExecutionListener.afterStep");
        if (inputFileName != null && (inputFileName.contains("abc"))) {
            return new ExitStatus("YES", "For processing step");
        }
        return new ExitStatus("NO", "For failed step");
    }
}

@Bean
public JobExecutionDecider decider() {
    return (jobExecution, stepExecution) -> {
        System.out.println(stepExecution.getExitStatus().getExitCode());
        if("YES".equals(stepExecution.getExitStatus().getExitCode())) {
            return new FlowExecutionStatus("YES");
        } else {
            return new FlowExecutionStatus("NO");
        }
    };
}

Stacktrace:

2023-04-03 15:41:42.865  INFO 17532 --- [  restartedMain] o.s.b.c.l.support.SimpleJobLauncher      : Job: [FlowJob: [name=job]] launched with the following parameters: [{RunDate=2023-04-03T15:41:41.080044100}]
2023-04-03 15:41:44.656  INFO 17532 --- [  restartedMain] o.s.batch.core.job.SimpleStepHandler     : Executing step: [initialStep]
MyStepExecutionListener.beforeStep
INTIAL STEP
MyStepExecutionListener.afterStep
2023-04-03 15:42:04.078  INFO 17532 --- [  restartedMain] o.s.batch.core.step.AbstractStep         : Step: [initialStep] executed in 19s422ms
2023-04-03 15:42:04.868  INFO 17532 --- [  restartedMain] o.s.b.c.l.support.SimpleJobLauncher      : Job: [FlowJob: [name=job]] completed with the following parameters: [{RunDate=2023-04-03T15:41:41.080044100}] and the following status: [FAILED] in 21s652ms

I am attaching the complete project as well to validate the issue.
demo.zip

Thanks!

[AJ198081]

Even if you aren't using the JobExecutionDecider and leveraging the Step's Exit Status, same issue manifests.

[acktsap]

It looks no transition state for exit status of initialStep (YES, NO). So it goes to FAILED state.

You can fix by settting transition for the exit code (YES, NO). Here is an example based on your code.

@Bean
Job job() throws Exception {
	return jobBuilderFactory
		.get("job")
		.incrementer(new RunIdIncrementer())
		.start(initialStep()).on("NO").to(decider())
		.from(initialStep()).on("YES").fail()
		.from(decider()).on("YES").to(process())
		.from(decider()).on("NO").to(failedStep()).end()
		.build();
}

It goes to decider when initialStep finishes with exit code NO. And it fails when initialStep finishes with exit code YES.

[AJ198081]

A couple of points -
1.There is a new JobBuilder for Spring-batch 5.X, and jobBuilderFactory is marked deprecated.
2. The issue is there even when there is a pattern and next state provided, please see https://github.com/spring-projects/spring-batch/issues/4348
I have added good screenshots of how the steps and associated patterns doesn't populate the stateTransition correctly, in the .from() branch