Omitting the name from the FlatFileItemReaderBuilder results in an exception. [BATCH-2623]

[spring-projects-issues]

Marten Deinum opened BATCH-2623 and commented

During conversion of a FlatFileItemReader to the usage of the FlatFileItemReaderBuilder I ran into the issue that I now suddenly must provide a name.

The FlatFileItemReader by default sets the name to the short classname and I would expect the builder to honor this, however instead the builder itself is throwing an exception. I would expect that I don't have the explicitly name the constructed reader just as with the plain configuration.

---

Affects: 4.0.0

[spring-projects-issues]

Michael Minella commented

We did that as a bit of a compromise to address the concerns related to BATCH-2108. The issue is that for some users, the short name of the class isn't specific enough. Ideally, that name field should be unique. While this doesn't address it completely (we don't provide any form of global validation to determine if a name truly is unique), enforcing that the user does set a name when saveState is set to true seemed like a reasonable way to decrease the likelihood that collisions would occur without breaking backwards compatibility. I'm willing to be convinced otherwise.

[spring-projects-issues]

Marten Deinum commented

Might be worth documenting that decision some where (in migration notes or something like that).

I migrated code from Spring Batch 3 to Spring Batch 4 and this took me by surprise (but that is what you get for writing a book against build snapshots :) ). Maybe change this into a documentation issue/task?