Skip to content

SslInfo does not use its Clock when checking certificate validity #45573

Open
@wilkinsona

Description

@wilkinsona

I noticed this as I was confused by SslMeterBinderTests where there are several certificates that are considered valid despite the tests using a fixed clock of 2024-10-21T13:51:40Z and the certificates not being valid until 2024-10-22.

While the Clock is new in 3.5, we may want to do something in 3.4 as well because SslInfoTests will start failing in the future when the certificates used for testing expire. They could prevent someone from rebuilding a tag unless they disable the tests.

Flagging for discussion so that we can decide what to do.

Metadata

Metadata

Assignees

No one assigned

    Labels

    for: team-meetingAn issue we'd like to discuss as a team to make progressstatus: waiting-for-triageAn issue we've not yet triaged

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions