Skip to content

QueryMethod uses non-final createParameters method #3263

Closed
4 of 5 issues completed
Closed
@mipo256

Description

@mipo256

When working on the following issue, I realized the QueryMethod is using the non-final (!) createParameters on this in the constructor. Because of this, we have a leaky constructor. The method createParameters is actually meant for implementations to be extended, it cannot be called in constructor of QueryMethod, since the child of QueryMethod is not yet fully constructed at the time createParameters is called.

What needs to be done: we need to call createParameters outside the constructor. Maybe we can consider calling it lazily.

Sub-issues

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions