`Criteria.regex` is converted to `String` when applying to ID fields

[spekdrum]

Hi, this issue #4649 is still happening in 4.2.4 with ID fields.

In QueryMapper#getMappedValue method, applyFiledTargetTypeHitToValue() returns the Pattern object correctly after the fix, but later ends calling QueryMapper#convertId() method, which ends calling getConversionService().canConvert() in MongoConverter.convertId() method. This is returning true, so Pattern is converted to String anyway.

[christophstrobl]

Thank you for getting in touch. It would help us investigating the issue if you could take the time to provide a complete minimal sample (something that we can unzip or git clone, build, and deploy) that reproduces the problem.

[spring-projects-issues]

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

[spekdrum]

Hi, I don't have the time right now for a full example, maybe next week.

Just create a query with a regexp on the key column, i.e.:

	final Query query = new Query();
	query.addCriteria(where(ID_FIELD).regex("^3517-"));			
	return this.mongoTemplate.find(query, RateRoomPricingData.class, RATES_COLLECTION);

This wont return any value because the regexp expression is lost due to conversion.

[spekdrum]

I built an example reproducing the problem:
mongo-demo.zip

In summary, the issue arises when filtering a collection by the _id field with a regexp. It doesn't return results because the resulting Pattern is being converted to a String. I showed the key lines involved in the conversion during a debugging session in my initial post.

Using spring boot 3.2.0+ the bug is reproduced, but using 3.1.11 it works ok.

I tried to enforce the spring-data-mongodb dependency version only, to 4.1.x, which is the working one, but the problem persists, so maybe the problem it's not fully up to this lib.

Code overview:

@SpringBootApplication
public class MongoDemoApplication {

	public static void main(final String[] args) {

		SpringApplication.run(MongoDemoApplication.class, args);
	}

	@Bean
	public CommandLineRunner commandLineRunner(final MongoTemplate mongoTemplate) {
		return args -> {
			final Query query = new Query();

			query.addCriteria(Criteria.where("_id").regex("^3517-"));

			final List<DocumentExample> documents = mongoTemplate.find(query, DocumentExample.class, "mycollection");

			documents.forEach(doc -> System.out.println(doc.getName()));
		};
	}
}

This should be the output when working ok:

test1
test2

but actually it prints nothing because this returns an empty list.

The attached example will be working as soon as you change spring boot parent to 3.1.11.

The collection is initialized this way in a init-mongo.js file:

db = db.getSiblingDB('testdb');
db.mycollection.insert([
	{_id: '3517-abv1', name: 'test1'},
	{_id: '3517-abz1', name: 'test2'},
	{_id: '2127-aswx', name: 'test3'}
]);
db.createUser({
	user: 'root',
	pwd: 'example',
	roles: [
		{role: 'readWrite', db: 'testdb'}
	]
});

[nandosangputra]

Hi, is there any updates on this issue? I also encountering the same issue ever since upgrading to springboot 3.2.0 with spring data mongodb 4.3.0

[christophstrobl]

@nandosangputra thanks for the ping.