From 176efa4aed4a979a52e8524c403a6b79a56809f3 Mon Sep 17 00:00:00 2001 From: ali dandach Date: Wed, 10 Apr 2024 01:29:21 +0300 Subject: [PATCH] Refactor SingleConnectionFactory to use try-with-resource Refactored SingleConnectionFactory in the spring-jms module to use try-with-resource for managing the JMS connection. This eliminates the necessity to explicitly close the connection, thereby enhancing code readability and exception handling. --- .../jms/connection/SingleConnectionFactory.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/spring-jms/src/main/java/org/springframework/jms/connection/SingleConnectionFactory.java b/spring-jms/src/main/java/org/springframework/jms/connection/SingleConnectionFactory.java index 2b52e7d751d3..36ad856f8488 100644 --- a/spring-jms/src/main/java/org/springframework/jms/connection/SingleConnectionFactory.java +++ b/spring-jms/src/main/java/org/springframework/jms/connection/SingleConnectionFactory.java @@ -575,14 +575,11 @@ protected void closeConnection(Connection con) { logger.debug("Closing shared JMS Connection: " + con); } try { - try { + try (con) { if (this.startedCount > 0) { con.stop(); } } - finally { - con.close(); - } } catch (jakarta.jms.IllegalStateException ex) { logger.debug("Ignoring Connection state exception - assuming already closed: " + ex);