Support ClickHouse in `BuiltInBindMarkersFactoryProvider`

[eddumelendez]

ClickHouse provides an r2dbc driver. Building a project with Testcontainers fails because of the following exception:

Caused by: org.springframework.r2dbc.core.binding.BindMarkersFactoryResolver$NoBindMarkersFactoryException: Cannot determine a BindMarkersFactory for ClickHouse using ConnectionPool[ClickHouse]

Add ClickHouse to the list

spring-framework/spring-r2dbc/src/main/java/org/springframework/r2dbc/core/binding/BindMarkersFactoryResolver.java

Lines 119 to 128 in 5e08a88

	static {
	BUILTIN.put("H2", BindMarkersFactory.indexed("$", 1));
	BUILTIN.put("MariaDB", BindMarkersFactory.anonymous("?"));
	BUILTIN.put("Microsoft SQL Server", BindMarkersFactory.named("@", "P", 32,
	BuiltInBindMarkersFactoryProvider::filterBindMarker));
	BUILTIN.put("MySQL", BindMarkersFactory.anonymous("?"));
	BUILTIN.put("Oracle", BindMarkersFactory.named(":", "P", 32,
	BuiltInBindMarkersFactoryProvider::filterBindMarker));
	BUILTIN.put("PostgreSQL", BindMarkersFactory.indexed("$", 1));
	}

My workaround was to created my own provider and register it in spring.factories but it fails because it also needs to support the ClickHouse dialect in spring-data-r2dbc.

[sdeleuze]

@eddumelendez I can probably perform related refinements to unlock future progresses on spring-data-r2dbc side. Just we need to decide which version we target. If you can submit a PR short term on Spring Data side, let's target Spring Framework 6.2, otherwise 7.0. Could you please share your timeline on Spring Data side?

[spring-projects-issues]

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

[eddumelendez]

Hi @sdeleuze, sorry for the delay. I can contribute to the spring-data-relational project by the end of the week. However, the issue there was closed because of team capacity and there is a comment in another PR adding a new dialect for the same reason.

[sdeleuze]

No problem, thanks for your feedback.

@mp911de Could you please let us know what you plan to do on Spring Data side. If you plan to reconsider a related PR, we will do the change on Spring Framework side. If not, we will decline.