Skip to content

Commit 05b4279

Browse files
committed
GH-2288 - Polishing.
1 parent c1ea6bf commit 05b4279

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

Diff for: etc/mappings.txt

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
assertj=AssertJ
12
jackson-bom=Jackson
23
junit=JUnit
34
kotlin=Kotlin

Diff for: etc/update-dependencies.sh

+8-5
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ if [ -z "$1" ] || [[ ! "$1" =~ ^(bugfix|minor|major)$ ]]; then
1010
fi
1111

1212
# Check GH milestones extension installed
13-
if [ -z $(gh extension list | grep "^gh milestone") ]; then
13+
if [ -z "$(gh extension list | grep "^gh milestone")" ]; then
1414
echo "gh milestones extension not installed. Install via: gh extension install valeriobelli/gh-milestone."
1515
exit 1;
1616
fi
@@ -60,13 +60,17 @@ while IFS= read -r line; do
6060

6161
if [[ $line =~ \$\{([[:alnum:]-]+)\.version\}[[:space:]\.]*([0-9]+\.[0-9]+\.[0-9]+.*)[[:space:]]\-\>[[:space:]]([0-9]+\.[0-9]+\.[0-9]+.*) ]]; then
6262

63+
echo "---"
64+
echo "Processing line: $line"
65+
6366
property_name="${BASH_REMATCH[1]}"
6467
old_version="${BASH_REMATCH[2]}"
6568
new_version="${BASH_REMATCH[3]}"
6669

6770
# Skip if new version matches pattern (case insensitive)
6871
if echo "$new_version" | grep -qiE "(-m[0-9]|-rc[0-9]|alpha|beta)"; then
69-
echo "Skipping milestone/alpha/beta version: $new_version"
72+
echo "Skipping preview version: $new_version."
73+
echo "---"
7074
continue
7175
fi
7276

@@ -94,8 +98,6 @@ while IFS= read -r line; do
9498
fi
9599

96100
matches_found=$((matches_found + 1))
97-
98-
echo "Processing line: $line"
99101

100102
# Look up the mapping directly
101103
mapping=$(grep "^${property_name}=" "$mapping_file" | cut -d '=' -f2)
@@ -136,7 +138,8 @@ while IFS= read -r line; do
136138
echo "Pushed changes and closed issue GH-${issue_number}"
137139
echo "---"
138140
else
139-
echo "Warning: No mapping found for property: $property_name"
141+
echo "No mapping found for property: $property_name. Skipping."
142+
echo "---"
140143
fi
141144
fi
142145
done < "$mvn_output_file"

0 commit comments

Comments
 (0)