Skip to content

Commit ed918e8

Browse files
refactor: Use Collection#isEmpty() instead of comparing size()
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.IsEmptyCallOnCollections?organizationId=ZDkzMDQ0M2YtNTIxOC00MWViLTkzZWQtMzQ2Zjk1ZjE0NTQw Co-authored-by: Moderne <[email protected]>
1 parent f8850d3 commit ed918e8

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

Diff for: src/main/java/org/springframework/hateoas/client/Traverson.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@ public Link asTemplatedLink() {
373373

374374
private Link traverseToLink(boolean expandFinalUrl) {
375375

376-
Assert.isTrue(rels.size() > 0, "At least one rel needs to be provided!");
376+
Assert.isTrue(!rels.isEmpty(), "At least one rel needs to be provided!");
377377

378378
return Link.of(expandFinalUrl ? traverseToExpandedFinalUrl().getUri().toString() : traverseToFinalUrl().getUri(),
379379
rels.get(rels.size() - 1).getRel());

Diff for: src/main/java/org/springframework/hateoas/mediatype/collectionjson/Jackson2CollectionJsonModule.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -524,7 +524,7 @@ public JsonSerializer<?> getContentSerializer() {
524524
@Override
525525
@SuppressWarnings("null")
526526
public boolean isEmpty(PagedModel<?> value) {
527-
return value.getContent().size() == 0;
527+
return value.getContent().isEmpty();
528528
}
529529

530530
/*

Diff for: src/main/java/org/springframework/hateoas/server/core/WebHandler.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ private static <T extends LinkBuilder> PreparedWebHandler<T> linkTo(Object invoc
140140
if (mappingVariable.isCapturing()) {
141141

142142
List<String> segments = Arrays.asList(((String) preparedValue).split("/"));
143-
Object value = segments.size() != 0 ? "/" + segment.composite().prepareAndEncode(segments) : "";
143+
Object value = !segments.isEmpty() ? "/" + segment.composite().prepareAndEncode(segments) : "";
144144

145145
values.put(key, value);
146146

0 commit comments

Comments
 (0)