Skip to content

Commit 1b97f49

Browse files
artembilanspring-builds
authored andcommitted
Fix timing and race conditions in the QueueChannelTests
(cherry picked from commit 8759a04)
1 parent d07dc70 commit 1b97f49

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

spring-integration-core/src/test/java/org/springframework/integration/channel/QueueChannelTests.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ public void testSimpleSendAndReceiveNonBlockingQueueWithTimeout() throws Excepti
8181
final QueueChannel channel = new QueueChannel(new ArrayDeque<>());
8282
ExecutorService exec = Executors.newSingleThreadExecutor();
8383
exec.execute(() -> {
84-
Message<?> message = channel.receive(1);
84+
Message<?> message = channel.receive(10000);
8585
if (message != null) {
8686
latch.countDown();
8787
}
@@ -115,6 +115,7 @@ public void testImmediateReceive() throws Exception {
115115
};
116116
singleThreadExecutor.execute(receiveTask2);
117117
assertThat(latch2.await(10, TimeUnit.SECONDS)).isTrue();
118+
assertThat(messageNull).isTrue();
118119
singleThreadExecutor.shutdownNow();
119120
}
120121

@@ -131,7 +132,7 @@ public void testBlockingReceiveWithNoTimeout() throws Exception {
131132
});
132133
exec.shutdownNow();
133134
assertThat(latch.await(10, TimeUnit.SECONDS)).isTrue();
134-
assertThat(messageNull.get()).isTrue();
135+
assertThat(messageNull).isTrue();
135136
}
136137

137138
@Test
@@ -141,13 +142,13 @@ public void testBlockingReceiveWithTimeout() throws Exception {
141142
final CountDownLatch latch = new CountDownLatch(1);
142143
ExecutorService exec = Executors.newSingleThreadExecutor();
143144
exec.execute(() -> {
144-
Message<?> message = channel.receive(10000);
145+
Message<?> message = channel.receive(1);
145146
messageNull.set(message == null);
146147
latch.countDown();
147148
});
148-
exec.shutdownNow();
149149
assertThat(latch.await(10, TimeUnit.SECONDS)).isTrue();
150-
assertThat(messageNull.get()).isTrue();
150+
assertThat(messageNull).isTrue();
151+
exec.shutdownNow();
151152
}
152153

153154
@Test

0 commit comments

Comments
 (0)