Skip to content

Commit 2cf2f10

Browse files
committed
Revert "GH-9455: Introduce IntegrationKeepAlive (#9493)"
This reverts commit 8f838d0.
1 parent cdcffd7 commit 2cf2f10

File tree

12 files changed

+1
-374
lines changed

12 files changed

+1
-374
lines changed

Diff for: spring-integration-core/src/main/java/org/springframework/integration/config/DefaultConfiguringBeanFactoryPostProcessor.java

-13
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
import org.springframework.integration.config.xml.IntegrationNamespaceUtils;
4545
import org.springframework.integration.context.IntegrationContextUtils;
4646
import org.springframework.integration.context.IntegrationProperties;
47-
import org.springframework.integration.endpoint.management.IntegrationKeepAlive;
4847
import org.springframework.integration.handler.LoggingHandler;
4948
import org.springframework.integration.handler.support.IntegrationMessageHandlerMethodFactory;
5049
import org.springframework.integration.json.JsonPathUtils;
@@ -130,7 +129,6 @@ public void postProcessBeanDefinitionRegistry(BeanDefinitionRegistry registry) t
130129
registerListMessageHandlerMethodFactory();
131130
registerIntegrationConfigurationReport();
132131
registerControlBusCommandRegistry();
133-
registerKeepAlive();
134132
}
135133

136134
@Override
@@ -462,15 +460,4 @@ private static BeanDefinitionBuilder createMessageHandlerMethodFactoryBeanDefini
462460
IntegrationContextUtils.ARGUMENT_RESOLVER_MESSAGE_CONVERTER_BEAN_NAME);
463461
}
464462

465-
private void registerKeepAlive() {
466-
if (!this.beanFactory.containsBean(IntegrationContextUtils.INTEGRATION_KEEP_ALIVE_BEAN_NAME)) {
467-
BeanDefinitionBuilder builder =
468-
BeanDefinitionBuilder.genericBeanDefinition(IntegrationKeepAlive.class)
469-
.setRole(BeanDefinition.ROLE_INFRASTRUCTURE);
470-
471-
this.registry.registerBeanDefinition(IntegrationContextUtils.INTEGRATION_KEEP_ALIVE_BEAN_NAME,
472-
builder.getBeanDefinition());
473-
}
474-
}
475-
476463
}

Diff for: spring-integration-core/src/main/java/org/springframework/integration/context/IntegrationContextUtils.java

-10
Original file line numberDiff line numberDiff line change
@@ -100,18 +100,8 @@ public abstract class IntegrationContextUtils {
100100

101101
public static final String LIST_MESSAGE_HANDLER_FACTORY_BEAN_NAME = "integrationListMessageHandlerMethodFactory";
102102

103-
/**
104-
* The bean name for the {@code org.springframework.integration.support.management.ControlBusCommandRegistry}.
105-
* @since 6.4
106-
*/
107103
public static final String CONTROL_BUS_COMMAND_REGISTRY_BEAN_NAME = "controlBusCommandRegistry";
108104

109-
/**
110-
* The bean name for the {@code org.springframework.integration.endpoint.management.IntegrationKeepAlive}.
111-
* @since 6.4
112-
*/
113-
public static final String INTEGRATION_KEEP_ALIVE_BEAN_NAME = "integrationKeepAlive";
114-
115105
/**
116106
* The default timeout for blocking operations like send and receive messages.
117107
* @since 6.1

Diff for: spring-integration-core/src/main/java/org/springframework/integration/context/IntegrationProperties.java

+1-29
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626
/**
2727
* Utility class to encapsulate infrastructure Integration properties constants and their default values.
28-
* The default values can be overridden by the {@code META-INF/spring.integration.properties} with these entries
28+
* The default values can be overridden by the {@code META-INF/spring.integration.properties} with this entries
2929
* (includes their default values):
3030
* <ul>
3131
* <li> {@code spring.integration.channels.autoCreate=true}
@@ -38,7 +38,6 @@
3838
* <li> {@code spring.integration.channels.error.requireSubscribers=true}
3939
* <li> {@code spring.integration.channels.error.ignoreFailures=true}
4040
* <li> {@code spring.integration.endpoints.defaultTimeout=30000}
41-
* <li> {@code spring.integration.keepAlive=true}
4241
* </ul>
4342
*
4443
* @author Artem Bilan
@@ -118,12 +117,6 @@ public final class IntegrationProperties {
118117
*/
119118
public static final String ENDPOINTS_DEFAULT_TIMEOUT = INTEGRATION_PROPERTIES_PREFIX + "endpoints.defaultTimeout";
120119

121-
/**
122-
* Set to {@code false} to fully disable Keep-Alive thread.
123-
* @since 6.4
124-
*/
125-
public static final String KEEP_ALIVE = INTEGRATION_PROPERTIES_PREFIX + "keepAlive";
126-
127120
private static final Properties DEFAULTS;
128121

129122
private boolean channelsAutoCreate = true;
@@ -146,8 +139,6 @@ public final class IntegrationProperties {
146139

147140
private long endpointsDefaultTimeout = IntegrationContextUtils.DEFAULT_TIMEOUT;
148141

149-
private boolean keepAlive = true;
150-
151142
private volatile Properties properties;
152143

153144
static {
@@ -321,30 +312,11 @@ public long getEndpointsDefaultTimeout() {
321312
/**
322313
* Configure a value for {@link #ENDPOINTS_DEFAULT_TIMEOUT} option.
323314
* @param endpointsDefaultTimeout the value for {@link #ENDPOINTS_DEFAULT_TIMEOUT} option.
324-
* @since 6.2
325315
*/
326316
public void setEndpointsDefaultTimeout(long endpointsDefaultTimeout) {
327317
this.endpointsDefaultTimeout = endpointsDefaultTimeout;
328318
}
329319

330-
/**
331-
* Return the value of {@link #KEEP_ALIVE} option.
332-
* @return the value of {@link #KEEP_ALIVE} option.
333-
* @since 6.4
334-
*/
335-
public boolean isKeepAlive() {
336-
return this.keepAlive;
337-
}
338-
339-
/**
340-
* Configure a value for {@link #KEEP_ALIVE} option.
341-
* Defaults {@code true} - set to {@code false} disable keep-alive thread.
342-
* @param keepAlive {@code false} to disable keep-alive thread.
343-
*/
344-
public void setKeepAlive(boolean keepAlive) {
345-
this.keepAlive = keepAlive;
346-
}
347-
348320
/**
349321
* Represent the current instance as a {@link Properties}.
350322
* @return the {@link Properties} representation.

Diff for: spring-integration-core/src/main/java/org/springframework/integration/endpoint/management/IntegrationKeepAlive.java

-150
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
/**
22
* Provides classes related to endpoint management.
33
*/
4-
@org.springframework.lang.NonNullApi
5-
@org.springframework.lang.NonNullFields
64
package org.springframework.integration.endpoint.management;

Diff for: spring-integration-core/src/main/resources/META-INF/spring.integration.default.properties

-1
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,3 @@ spring.integration.messagingTemplate.throwExceptionOnLateReply=false
99
spring.integration.readOnly.headers=
1010
spring.integration.endpoints.noAutoStartup=
1111
spring.integration.endpoints.defaultTimeout=30000
12-
spring.integration.keepAlive=true

Diff for: spring-integration-core/src/test/java/org/springframework/integration/context/IntegrationContextTests.java

-5
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import org.springframework.beans.factory.annotation.Autowired;
2222
import org.springframework.beans.factory.annotation.Qualifier;
2323
import org.springframework.integration.endpoint.AbstractEndpoint;
24-
import org.springframework.integration.endpoint.management.IntegrationKeepAlive;
2524
import org.springframework.integration.test.util.TestUtils;
2625
import org.springframework.scheduling.concurrent.ThreadPoolTaskScheduler;
2726
import org.springframework.test.annotation.DirtiesContext;
@@ -53,9 +52,6 @@ public class IntegrationContextTests {
5352
@Autowired
5453
private ThreadPoolTaskScheduler taskScheduler;
5554

56-
@Autowired
57-
private IntegrationKeepAlive integrationKeepAlive;
58-
5955
@Test
6056
public void testIntegrationContextComponents() {
6157
assertThat(this.integrationProperties.isMessagingTemplateThrowExceptionOnLateReply()).isTrue();
@@ -66,7 +62,6 @@ public void testIntegrationContextComponents() {
6662
assertThat(this.serviceActivator.isRunning()).isFalse();
6763
assertThat(this.serviceActivatorExplicit.isAutoStartup()).isTrue();
6864
assertThat(this.serviceActivatorExplicit.isRunning()).isTrue();
69-
assertThat(this.integrationKeepAlive.isRunning()).isTrue();
7065
}
7166

7267
}

0 commit comments

Comments
 (0)