Skip to content

Commit 3349544

Browse files
Kehrlannmarcusdacoregio
authored andcommitted
Hardcode ott-username input name in DefaultLoginPageGeneratingFilter
- GenerateOneTimeTokenFilter uses `"username"`, the default UI should use the same parameter name
1 parent c0a10b9 commit 3349544

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

web/src/main/java/org/springframework/security/web/authentication/ui/DefaultLoginPageGeneratingFilter.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -242,8 +242,8 @@ private String generateLoginPageHtml(HttpServletRequest request, boolean loginEr
242242
sb.append(" <h2>Request a One-Time Token</h2>\n");
243243
sb.append(createError(loginError, errorMsg) + createLogoutSuccess(logoutSuccess) + "<p>\n");
244244
sb.append(" <label for=\"ott-username\" class=\"screenreader\">Username</label>\n");
245-
sb.append(" <input type=\"text\" id=\"ott-username\" name=\"" + this.usernameParameter
246-
+ "\" placeholder=\"Username\" required>\n");
245+
sb.append(
246+
" <input type=\"text\" id=\"ott-username\" name=\"username\" placeholder=\"Username\" required>\n");
247247
sb.append(" </p>\n");
248248
sb.append(renderHiddenInputs(request));
249249
sb.append(" <button class=\"primary\" type=\"submit\" form=\"ott-form\">Send Token</button>\n");

web/src/test/java/org/springframework/security/web/authentication/DefaultLoginPageGeneratingFilterTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ public void generateWhenOneTimeTokenLoginThenOttForm() throws Exception {
199199
<h2>Request a One-Time Token</h2>
200200
<p>
201201
<label for="ott-username" class="screenreader">Username</label>
202-
<input type="text" id="ott-username" name="null" placeholder="Username" required>
202+
<input type="text" id="ott-username" name="username" placeholder="Username" required>
203203
</p>
204204
<button class="primary" type="submit" form="ott-form">Send Token</button>
205205
</form>

0 commit comments

Comments
 (0)