From f6d6f46a81797ba57f5ee02f42d7435e8a0ef465 Mon Sep 17 00:00:00 2001 From: Anubhav Ahlawat Date: Tue, 28 Feb 2023 15:59:01 +0530 Subject: [PATCH] Added null assertions for the parameters in Saml2LogoutRequest constructor --- .../service/authentication/logout/Saml2LogoutRequest.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/provider/service/authentication/logout/Saml2LogoutRequest.java b/saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/provider/service/authentication/logout/Saml2LogoutRequest.java index b234935b11e..7c5cf740ad1 100644 --- a/saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/provider/service/authentication/logout/Saml2LogoutRequest.java +++ b/saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/provider/service/authentication/logout/Saml2LogoutRequest.java @@ -28,6 +28,7 @@ import org.springframework.security.saml2.provider.service.registration.RelyingPartyRegistration; import org.springframework.security.saml2.provider.service.registration.Saml2MessageBinding; import org.springframework.security.saml2.provider.service.web.authentication.logout.Saml2LogoutRequestResolver; +import org.springframework.util.Assert; import org.springframework.web.util.UriComponentsBuilder; import org.springframework.web.util.UriUtils; @@ -69,6 +70,12 @@ private Saml2LogoutRequest(String location, Saml2MessageBinding binding, Map parameters, String id, String relyingPartyRegistrationId, Function, String> encoder) { + Assert.notNull(location, "location cannot be null"); + Assert.notNull(binding, "binding cannot be null"); + Assert.notNull(parameters, "parameters cannot be null"); + Assert.notNull(id, "id cannot be null"); + Assert.notNull(relyingPartyRegistrationId, "relyingPArtyRegistrationId cannot be null"); + Assert.notNull(encoder, "encoder cannot be null"); this.location = location; this.binding = binding; this.parameters = Collections.unmodifiableMap(new LinkedHashMap<>(parameters));