Quit builtin command is not autocompleted

[AlexFalappa]

While playing around with a sample Spring Shell 4 application I noticed that in interactive mode all builtin commands are auto completed except quit and its alias exit.

[czpilar]

Also other aliases are not autocompleted...

Consider this configuration:

package org.springframework.shell.samples.helloworld.boot;

import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
import org.springframework.shell.core.command.annotation.Command;
import org.springframework.shell.core.command.annotation.Option;

@SpringBootApplication
public class SpringShellApplication {

	public static void main(String[] args) {
		SpringApplication.run(SpringShellApplication.class, args);
	}

	@Command(name = "hello", alias = { "bye", "hi" })
	public void sayHello(@Option(longName = "name") String name) {
		System.out.println("Hello " + name);
	}

}

And pressing tab does nothing.

shell:>b

[czpilar]

Both issues fixed in #1299

[fmbenhassine]

@AlexFalappa Thank you for opening this issue, which is valid. I will plan the fix for 4.0.1.

@czpilar Thank you for the PR!

Also other aliases are not autocompleted...

Just a note about this, alias completion does not work in v3 neither. Here is a quick reproducer :

demo-v3-alias-completion.zip

shell:>greeting he

Pressing tab at this point prints nothing.

[czpilar]

@fmbenhassine so we do not want to autocomplete aliases? If not, I can rework this PR by tomorrow...

[fmbenhassine]

No, not because it doesn't work in v3 that we need to keep it broken in v4. Your PR LGTM and I merged it, thank you!

My point is that I see many issues attributed to v4 but they are in v3 as well, here is another one: #1279.

Another point as well: There are some things that make sense to keep or "restore" (I see them as regressions) like #1286 or #1282, but not because something was working in a certain way in v3 that it should be replicated as is in v4. We need to make this clear in the migration guide.

[czpilar]

@fmbenhassine sure.. it is up to you. I am just trying to help b/c we use spring shell in our company product as well. If any of my PR does not make sense just let me know I can rework them or you can close them without merging... I am fine with that.

[fmbenhassine]

I was talking in general about issues I see recently reported by other users than you against v4 while they are in v3 as well. I hope my previous message was not implying anything about your contributions, because you are doing an amazing job helping with all these fixes as I already mentioned elsewhere. Thanks again 🙏

[czpilar]

@fmbenhassine No, no... your message was fine... I can help whenever I can...