Skip to content

Commit 171a17c

Browse files
authored
fix: revert battery_rate_min threshold change, keep only stale variable fix
battery_rate_min is a simulation field indicating minimum discharge power when rate is set to 0; it does not clamp actual charge/discharge rates. Revert to == 0 comparison and retain only the Bug 1 fix (stale `inverter` variable replaced with `inverters[id]`).
1 parent 825cf4b commit 171a17c

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

apps/predbat/execute.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1103,12 +1103,11 @@ def balance_inverters(self, test_mode=False):
11031103
inverters[this_inverter].adjust_discharge_rate(0, notify=False)
11041104

11051105
for id in range(num_inverters):
1106-
min_rate = inverters[id].battery_rate_min * MINUTE_WATT
1107-
if not balance_reset_charge.get(id, False) and total_charge_rates > 0 and charge_rates[id] <= min_rate:
1108-
self.log("BALANCE: Inverter {} reset charge rate to {} now balanced (was {}W)".format(id, inverters[id].battery_rate_max_charge * MINUTE_WATT, charge_rates[id]))
1106+
if not balance_reset_charge.get(id, False) and total_charge_rates > 0 and charge_rates[id] == 0:
1107+
self.log("BALANCE: Inverter {} reset charge rate to {} now balanced".format(id, inverters[id].battery_rate_max_charge * MINUTE_WATT))
11091108
inverters[id].adjust_charge_rate(inverters[id].battery_rate_max_charge * MINUTE_WATT, notify=False)
1110-
if not balance_reset_discharge.get(id, False) and total_discharge_rates != 0 and discharge_rates[id] <= min_rate:
1111-
self.log("BALANCE: Inverter {} reset discharge rate to {} now balanced (was {}W)".format(id, inverters[id].battery_rate_max_discharge * MINUTE_WATT, discharge_rates[id]))
1109+
if not balance_reset_discharge.get(id, False) and total_discharge_rates != 0 and discharge_rates[id] == 0:
1110+
self.log("BALANCE: Inverter {} reset discharge rate to {} now balanced".format(id, inverters[id].battery_rate_max_discharge * MINUTE_WATT))
11121111
inverters[id].adjust_discharge_rate(inverters[id].battery_rate_max_discharge * MINUTE_WATT, notify=False)
11131112

11141113
self.log("BALANCE: Completed this run")

0 commit comments

Comments
 (0)