The library should not use console.error internally, because it is not compatible with any custom logging flow (for example sending json formatted logs, to use in most SAAS logging analysis platform).
This specific console.error is causing some issues on our own integration:
https://github.com/spruceid/siwe/blob/main/packages/siwe/lib/client.ts#L297
/** Recover address from signature */
let addr;
try {
addr = (0, ethersCompat_1.verifyMessage)(EIP4361Message, signature);
}
catch (e) {
console.error(e);
}
I think it should return the error directly (or catch & reformat it), but not log it internally.
The library should not use
console.errorinternally, because it is not compatible with any custom logging flow (for example sending json formatted logs, to use in most SAAS logging analysis platform).This specific
console.erroris causing some issues on our own integration:https://github.com/spruceid/siwe/blob/main/packages/siwe/lib/client.ts#L297
I think it should return the error directly (or catch & reformat it), but not log it internally.