Merge pull request #553 from jitseniesen/commbase-bug

PR: Fix bug when converting JSON to StackSummary

Author: ccordoba12

spyder_kernels/comms/commbase.py

@@ -81,9 +81,9 @@ def stacksummary_to_json(stack):
     ]
 
 
-def staksummary_from_json(stack):
+def stacksummary_from_json(stack):
     """StackSummary from json."""
-    traceback.StackSummary.from_list([
+    return traceback.StackSummary.from_list([
         (
             frame["filename"],
             frame["lineno"],
@@ -127,7 +127,7 @@ def from_json(cls, json_data):
         instance.error = instance.etype(*json_data["args"])
         if json_data["error_name"]:
             instance.error.name = json_data["error_name"]
-        instance.tb = staksummary_from_json(json_data["tb"])
+        instance.tb = stacksummary_from_json(json_data["tb"])
         return instance
 
     def raise_error(self):

spyder_kernels/comms/tests/test_commbase.py

@@ -0,0 +1,29 @@
+# -*- coding: utf-8 -*-
+# -----------------------------------------------------------------------------
+# Copyright (c) 2025- Spyder Kernels Contributors
+#
+# Licensed under the terms of the MIT License
+# (see spyder_kernels/__init__.py for details)
+# -----------------------------------------------------------------------------
+
+"""
+Tests for commbase.py
+"""
+
+# Local imports
+from spyder_kernels.comms.commbase import (
+    stacksummary_from_json,
+    stacksummary_to_json,
+)
+
+
+def test_stacksummary_roundtrip():
+    """
+    Test that roundtripping a JSON representation of a StackSummary works.
+    """
+    json = [
+        {"filename": "f1", "lineno": 42, "name": "n1", "line": "l1"},
+        {"filename": "f2", "lineno": 42, "name": "n2", "line": "l2"},
+    ]
+    stacksummary = stacksummary_from_json(json)
+    assert stacksummary_to_json(stacksummary) == json