Skip to content

Commit 1b07d88

Browse files
Apply suggestions from CAM's code review
Co-authored-by: C.A.M. Gerlach <[email protected]>
1 parent 9b3ff93 commit 1b07d88

File tree

2 files changed

+27
-30
lines changed

2 files changed

+27
-30
lines changed

β€ŽCONTRIBUTING.mdβ€Ž

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -37,20 +37,20 @@ Thank you for your interest in contributing to the Spyder website! This guide wi
3737
## Development Setup
3838

3939
1. **Install dependencies**:
40-
```bash
40+
```shell
4141
npm install
4242
```
4343

4444
2. **Start the development server**:
45-
```bash
45+
```shell
4646
npm run dev
4747
```
48-
The site will be available at `http://localhost:5173`
4948

50-
3. **Available scripts**:
51-
- `npm run dev` - Start development server
52-
- `npm run build` - Build for production
53-
- `npm run preview` - Preview production build
49+
3. View the site at [http://localhost:5173](http://localhost:5173)
50+
**Available scripts**:
51+
- `npm run dev` - Start development server
52+
- `npm run build` - Build for production
53+
- `npm run preview` - Preview production build
5454

5555
## Types of Contributions
5656

@@ -94,7 +94,7 @@ If the blog post author(s) haven't been added yet:
9494
---
9595
```
9696

97-
3. **Write content** using mdsvex Markdown:
97+
3. **Write content** using [mdsvex](https://mdsvex.pngwn.io/) Markdown:
9898
- [Never indent code blocks](https://mdsvex.pngwn.io/docs#limitations)
9999
- Use standard Markdown syntax for formatting
100100
- Follow our [style guide](#style-guidelines) for consistency
@@ -108,7 +108,7 @@ If the blog post author(s) haven't been added yet:
108108
- Prefer WEBP format for better performance
109109

110110
5. **Preview your post**:
111-
```bash
111+
```shell
112112
npm run dev
113113
```
114114
- Verify post appears at `/blog/your-post-name`
@@ -135,8 +135,8 @@ If the blog post author(s) haven't been added yet:
135135

136136
Before creating an issue:
137137

138-
1. **Search existing issues** to avoid duplicates
139-
2. **Use the issue template** (if available)
138+
1. **Search [existing issues](https://github.com/spyder-ide/spyder-website/issues)** to avoid duplicates
139+
2. **Complete all relevant fields of the issue template**
140140
3. **Include relevant details**:
141141
- Clear description of the problem
142142
- Steps to reproduce
@@ -147,7 +147,7 @@ Before creating an issue:
147147
## Pull Request Process
148148

149149
1. **Ensure your changes work locally**:
150-
```bash
150+
```shell
151151
npm run dev
152152
# Test your changes thoroughly
153153
```
@@ -193,7 +193,7 @@ Before creating an issue:
193193

194194
If you have questions or need help:
195195

196-
- Check existing [documentation](README.md)
196+
- Check the [documentation](./README.md)
197197
- Search [existing issues](https://github.com/spyder-ide/spyder-website/issues)
198198
- Create a new issue with the "question" label
199199

β€ŽREADME.mdβ€Ž

Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ This website is built with modern web technologies:
2929
- **Content**: [mdsvex](https://mdsvex.pngwn.io/) - Markdown processor for Svelte
3030
- **Icons**: [Svelte Icons Pack](https://leshak.github.io/svelte-icons-pack/) - Icon library
3131
- **Deployment**: [GitHub Pages](https://pages.github.com/) - Static site hosting
32-
- **CI/CD**: GitHub Actions - Automated deployment
32+
- **CI/CD**: [GitHub Actions](https://github.com/features/actions) - Automated deployment
3333

3434
## Features
3535

@@ -49,21 +49,21 @@ This website is built with modern web technologies:
4949
- [Node.js](https://nodejs.org/) (version 18 or higher)
5050
- [npm](https://www.npmjs.com/) (comes with Node.js)
5151

52-
### Development Setup
52+
### Build locally
5353

5454
1. **Clone the repository**:
55-
```bash
55+
```shell
5656
git clone https://github.com/spyder-ide/spyder-website.git
5757
cd spyder-website
5858
```
5959

6060
2. **Install dependencies**:
61-
```bash
61+
```shell
6262
npm install
6363
```
6464

6565
3. **Start development server**:
66-
```bash
66+
```shell
6767
npm run dev
6868
```
6969

@@ -83,10 +83,10 @@ This website is built with modern web technologies:
8383

8484
## Project Structure
8585

86-
```
86+
```text
8787
spyder-website/
8888
β”œβ”€β”€ src/
89-
β”‚ β”œβ”€β”€ routes/ # Page routes and content
89+
β”‚ β”œβ”€β”€ routes/ # Page routes and content
9090
β”‚ β”‚ β”œβ”€β”€ +page.svelte # Homepage
9191
β”‚ β”‚ β”œβ”€β”€ about/ # About page
9292
β”‚ β”‚ β”œβ”€β”€ blog/ # Blog posts and pages
@@ -133,33 +133,33 @@ The built site will be available at [http://localhost:5174](http://localhost:517
133133

134134
We welcome contributions from the community! Please see our [Contributing Guide](CONTRIBUTING.md) for details on:
135135

136+
- Reporting issues
136137
- Setting up the development environment
137138
- Creating blog posts
138139
- Making code contributions
139140
- Submitting pull requests
140-
- Reporting issues
141141

142142
### Quick Contribution Steps
143143

144-
1. Fork this repository
145-
2. Create a feature branch (`git checkout -b feature/amazing-feature`)
144+
1. Fork and clone this repository
145+
2. Create a topic branch (`git switch -c topic-branch-name-here`)
146146
3. Make your changes
147147
4. Test locally (`npm run dev`)
148148
5. Commit your changes (`git commit -m 'Add amazing feature'`)
149-
6. Push to your branch (`git push origin feature/amazing-feature`)
150-
7. Open a Pull Request
149+
6. Push your branch to your fork (`git push -u origin topic-branch-name-here`)
150+
7. Open a [Pull Request](https://github.com/spyder-ide/spyder-website/pull/new)
151151

152152
## Community
153153

154154
- 🐍 **Main Project**: [Spyder IDE](https://github.com/spyder-ide/spyder)
155155
- πŸ’¬ **Discussions**: [GitHub Discussions](https://github.com/spyder-ide/spyder/discussions)
156-
- πŸ› **Issues**: [Bug Reports](https://github.com/spyder-ide/spyder/issues)
156+
- πŸ› **Issues**: [Bug Reports](https://github.com/spyder-ide/spyder-website/issues)
157157
- πŸ“§ **Mailing List**: [Google Groups](https://groups.google.com/group/spyderlib)
158158
- 🐦 **Twitter**: [@Spyder_IDE](https://twitter.com/Spyder_IDE)
159159

160160
## License
161161

162-
This project is licensed under the MIT License - see the [LICENSE.md](LICENSE.md) file for details.
162+
This project is released under the MIT License - see the [LICENSE.md](./LICENSE.md) file for details.
163163

164164
## Acknowledgments
165165

@@ -168,6 +168,3 @@ This project is licensed under the MIT License - see the [LICENSE.md](LICENSE.md
168168
- Powered by [SvelteKit](https://kit.svelte.dev/) and [TailwindCSS](https://tailwindcss.com/)
169169
- Hosted on [GitHub Pages](https://pages.github.com/)
170170

171-
---
172-
173-
*Made with love for the Python community*

0 commit comments

Comments
Β (0)