Utils: Rename "dependency_ok" icon to "success"

That's a more meaningful name and it can be used more broadly too.

[ci skip]

Author: ccordoba12

spyder/plugins/shortcuts/widgets/table.py

@@ -423,7 +423,7 @@ def update_warning(self):
         else:
             warning = NO_WARNING
             tip = _('This key sequence is valid.')
-            icon = ima.icon('dependency_ok')
+            icon = ima.icon('success')
 
         self.warning = warning
         self.conflicts = conflicts

spyder/utils/icon_manager.py

@@ -175,6 +175,7 @@ def __init__(self):
             'toggle_lowercase':        [('mdi.format-letter-case-lower',), {'color': self.MAIN_FG_COLOR}],
             'toggle_uppercase':        [('mdi.format-letter-case-upper',), {'color': self.MAIN_FG_COLOR}],
             'gotoline':                [('mdi.format-line-spacing',), {'color': self.MAIN_FG_COLOR}],
+            'success':                 [('mdi.check',), {'color': SpyderPalette.COLOR_SUCCESS_3}],
             'error':                   [('mdi.close-circle',), {'color': SpyderPalette.COLOR_ERROR_1}],
             'warning':                 [('mdi.alert',), {'color': SpyderPalette.COLOR_WARN_2}],
             'information':             [('mdi.information-outline',), {'color': SpyderPalette.GROUP_9}],
@@ -383,7 +384,6 @@ def __init__(self):
             'folding.arrow_down':      [('mdi.chevron-down',), {'color': self.MAIN_FG_COLOR}],
             'lspserver.down':          [('mdi.alert',), {'color': self.MAIN_FG_COLOR}],
             'lspserver.ready':         [('mdi.check',), {'color': self.MAIN_FG_COLOR}],
-            'dependency_ok':           [('mdi.check',), {'color': SpyderPalette.COLOR_SUCCESS_2}],
             'dependency_warning':      [('mdi.alert',), {'color': SpyderPalette.COLOR_WARN_2}],
             'dependency_error':        [('mdi.alert',), {'color': SpyderPalette.COLOR_ERROR_1}],
             'broken_image':            [('mdi.image-broken-variant',), {'color': self.MAIN_FG_COLOR}],

spyder/widgets/dependencies.py

@@ -61,7 +61,7 @@ def update_dependencies(self, dependencies):
 
             # Format content
             if dependency.check():
-                item.setIcon(0, ima.icon('dependency_ok'))
+                item.setIcon(0, ima.icon('success'))
             elif dependency.kind == OPTIONAL:
                 item.setIcon(0, ima.icon('dependency_warning'))
                 item.setBackground(2, QColor(SpyderPalette.COLOR_WARN_1))