Tests get installed along with the package

[juliangilbey]

The directory called tests is included in the build of three_merge because it is a subdirectory of it. It should probably be on the same level, and then the tests will be run but not installed in the final package; this seems to be standard practice. The following command should do the job: git mv three_merge/tests tests

[ccordoba12]

@andfoy, what do you think about this one?

[clach04]

This is a style/opinion issue. I happen to be in the tests should ship in the module/package camp.

https://python-packaging.readthedocs.io/en/latest/testing.html shows this as a best practice. It can be useful (albeit likely rare) to allow running tests of an installed version on a machine with a less advanced user (as a sanity check for the enviroment).

[juliangilbey]

Interesting. That website has not been updated for about 12 years, so while that might have been considered best practice then by the authors, I don't know what is considered best practice today. Most users would presumably not be interested in running the tests on a live system, and any who do could download the source package from GitHub or PyPI and run the tests directly. If the tests are appropriately written, they can be used with the installed package rather than the version in the source package.