Add JsonClass.inline #2052
Open
Add JsonClass.inline #2052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
reviewed
Nov 25, 2025
Collaborator
swankjesse
left a comment
swankjesse
left a comment
There was a problem hiding this comment.
I think it’s ambiguous in the case where the property is nullable?
@JsonClass(generateAdapter = true, inline = true)
data class Location(val point: Point?)Decoding [null] as a List<Location?> could be listOf(Location(null)) or listOf(null).
I think we gotta make a call here!
| } | ||
|
|
||
| @Test | ||
| fun inlineClassWithMultiplePropertiesFails() { |
moshi-kotlin-tests/src/test/kotlin/com/squareup/moshi/kotlin/DualKotlinTest.kt
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
Prohibited nullable props in 24d409a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in the changelog, but in short this unlocks the ability to match behavior like kotlinx.serialization's support for inlining the single value in JSON.
One primary question here is: what do we do about default values in this scenario? Right now it doesn't support absence
A secondary question could be to make this its own
@JsonInlineannotation rather than part of@JsonClass