Change user-agent on connect request?

[regbo]

Forgive me if there is a solution for this, but I can't seem to find a way to change the User-Agent header on a connect request. It seems like it's hard coded to:

User-Agent: okhttp/4.10.0

I can change it with reflection, but we have a situation where a server needs the user agent to match all requests moving forward. Is there a way to do it? Perhaps it could be acheived with this enhancement?

#7297

[swankjesse]

No way to manipulate this currently. I'm not even sure where we'd add that configuration option in our API.

[regbo]

No way to manipulate this currently. I'm not even sure where we'd add that configuration option in our API.

Perhaps just copy the value sent with the request initiating the connect?

[swankjesse]

That's the most obvious option. The drawback is that the request that creates the tunnel is arbitrary. If you have a connection that carries multiple requests, they may each use different user-agents. In general we're pretty allergic to data leakage like this.

For regular applications it's unlikely to matter but it's possible for OkHttp to be used inside a proxy or gateway where the requests are truly independent.

[regbo]

Right. What about a default user agent tied to the connection pool?

Or somehow allow intercepting on the Real connection?

[yschimke]

Should User-Agent be configurable on OkHttpClient?

The hardcoded default seems like the issue here.

okhttp/okhttp/src/jvmMain/kotlin/okhttp3/internal/http/BridgeInterceptor.kt

Line 80 in 5c62ed7

requestBuilder.header("User-Agent", userAgent)

import okhttp3.internal.userAgent

[yschimke]

@swankjesse would you object to allow setting the user agent on the client?

[swankjesse]

Sure. That one would be preferred over our default, but we’d still honor whatever came from a Request or Interceptor.