handle null or empty cases better

Author: khepin

Makefile

@@ -1,9 +1,9 @@
 ci-php80:
-	./vendor/bin/phpcs --standard=PSR2  src/ tests/
 	./vendor/bin/phpunit --testsuite php80
+	./vendor/bin/phpcs --standard=PSR2  src/ tests/
 	vendor/bin/phpstan analyse src tests --level 5 -c phpstan.php80.neon
 
 ci-php81:
-	./vendor/bin/phpcs --standard=PSR2  src/ tests/
 	./vendor/bin/phpunit --testsuite php81
+	./vendor/bin/phpcs --standard=PSR2  src/ tests/
 	vendor/bin/phpstan analyse src tests --level 5 -c phpstan.neon

src/Integrations/Laravel/JsonCaster.php

@@ -13,11 +13,15 @@ public function __construct(
 
     public function get($model, $key, $value, $attributes)
     {
+        if ($value === null || $value === '') {
+            return $value;
+        }
+
         return $this->target::fromJsonString($value);
     }
 
     public function set($model, $key, $value, $attributes)
     {
-        return $value->toJson();
+        return $value?->toJson();
     }
 }

tests/Integrations/Laravel/LaravelCastTest.php

@@ -42,4 +42,44 @@ public function testCasts()
         $this->assertEquals(Address::class, get_class($oaddr));
         $this->assertEquals($addr, $oaddr->toJson());
     }
+
+    public function testNullCase()
+    {
+        (new FirstModel([
+            'name' => 'jane',
+            'castable_address' => null,
+            'address' => null,
+        ]))->save();
+        $m = FirstModel::query()->first();
+        $this->assertTrue(null === $m->getAttributes()['castable_address']);
+        $this->assertTrue(null === $m->castable_address);
+        $this->assertTrue(null === $m->getAttributes()['address']);
+        $this->assertTrue(null === $m->address);
+    }
+
+    public function testNotSet()
+    {
+        (new FirstModel([
+            'name' => 'jane',
+        ]))->save();
+        $m = FirstModel::query()->first();
+        $this->assertTrue(null === $m->getAttributes()['castable_address']);
+        $this->assertTrue(null === $m->castable_address);
+        $this->assertTrue(null === $m->getAttributes()['address']);
+        $this->assertTrue(null === $m->address);
+    }
+
+    public function testEmptyString()
+    {
+        FirstModel::query()->insert([
+            'name' => 'jane',
+            'castable_address' => '',
+            'address' => '',
+        ]);
+        $m = FirstModel::query()->first();
+        $this->assertTrue('' === $m->getAttributes()['castable_address']);
+        $this->assertTrue('' === $m->castable_address);
+        $this->assertTrue('' === $m->getAttributes()['address']);
+        $this->assertTrue('' === $m->address);
+    }
 }