Retrofit 2 Close ErrorResponse Body

[paourissi]

I am using retrofit 2 and I was wondering if i have to call the close function when receiving an error body or retrofit closes it automatically?.

public void onResponse(Call call, Response response) {
if (response.isSuccessful()) {
// Success
} else {
response.errorBody().close(); ???????????????????
}
}

Thank you

[NightlyNexus]

The error body's source is buffered completely and closed by Retrofit.

retrofit/retrofit/src/main/java/retrofit2/OkHttpCall.java

Line 212 in 5088b0d

rawBody.close();

[JakeWharton]

Sounds like we just need a sentence in the documentation

[paourissi]

@JakeWharton @NightlyNexus
So everything is closed by retrofit automatically?
Then why is there a close function?
Also when does the close function takes place? After the callback's execution or before?
The same goes for the response.body()?

[JakeWharton]

For the same reason there's a close on InputStream despite ByteArrayInputStream not requiring you to close. But yes, unless you are @streaming you do not need to close anything.

…

On Thu, Oct 18, 2018 at 3:44 PM George Paouris ***@***.***> wrote: @JakeWharton <https://github.com/JakeWharton> @NightlyNexus <https://github.com/NightlyNexus> So everything is closed by retrofit automatically? Then why is there a close function? Also when does the close function takes place? After the callback's execution or before? The same goes for the response.body()? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2929 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEEESvnG8HPydZ9FB_1Hk4laYWW1ctGks5umNofgaJpZM4Xtxjh> .

[paourissi]

@JakeWharton

For the same reason there's a close on InputStream despite ByteArrayInputStream not requiring you to close. But yes, unless you are @streaming you do not need to close anything.
…
On Thu, Oct 18, 2018 at 3:44 PM George Paouris @.***> wrote: @JakeWharton https://github.com/JakeWharton @NightlyNexus https://github.com/NightlyNexus So everything is closed by retrofit automatically? Then why is there a close function? Also when does the close function takes place? After the callback's execution or before? The same goes for the response.body()? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2929 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEESvnG8HPydZ9FB_1Hk4laYWW1ctGks5umNofgaJpZM4Xtxjh .

And what reason should that be?

[JakeWharton]

Modeling more than one source of data On Thu, Oct 18, 2018 at 4:01 PM George Paouris <notifications@github.com> wrote:

…

@JakeWharton <https://github.com/JakeWharton> For the same reason there's a close on InputStream despite ByteArrayInputStream not requiring you to close. But yes, unless you are @streaming <https://github.com/streaming> you do not need to close anything. … <#m_561261150799913299_> On Thu, Oct 18, 2018 at 3:44 PM George Paouris ***@***.***> wrote: @JakeWharton <https://github.com/JakeWharton> https://github.com/JakeWharton @NightlyNexus <https://github.com/NightlyNexus> https://github.com/NightlyNexus So everything is closed by retrofit automatically? Then why is there a close function? Also when does the close function takes place? After the callback's execution or before? The same goes for the response.body()? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2929 (comment) <#2929 (comment)>>, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEESvnG8HPydZ9FB_1Hk4laYWW1ctGks5umNofgaJpZM4Xtxjh . And what reason should that be? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2929 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEEEdODZn3AQRBy0xcY1hxJy0FX0eUwks5umN4QgaJpZM4Xtxjh> .

[MonikaJethani]

@JakeWharton Is this done? If pending, Can I work on this?