Add (async done body) macro for cljs.test parity

Adds core-async to the built-in test macros: (async done body)
expands to (js/Promise. (fn [done] body)). The deftest body returns
the Promise and test-var awaits it, so no ^:async marker on the
outer fn is needed. Lets users copy-paste cljs.test code that uses
the (async done ...) idiom without rewriting it.

Also added to builtin-refer-is-macro? so :refer [async] doesn't
emit a runtime import. Smoke test gets a regression. CHANGELOG and
TODO entries updated (#8 closed).

Author: borkdude

CHANGELOG.md

@@ -5,10 +5,11 @@
 ## Unreleased
 
 - Add built-in `cljs.test` / `clojure.test` support: `deftest`, `is`, `testing`,
-  `are`, `deftest-`, `use-fixtures`, `run-tests` (no-args defaults to current ns;
-  also accepts quoted ns symbols, e.g. `(run-tests 'my.ns)`). Per-namespace
-  fixtures, counter isolation per `run-tests` call, `^:async` test support.
-  Runtime ships at `squint-cljs/src/squint/test.mjs`.
+  `are`, `deftest-`, `use-fixtures`, `async`, `run-tests` (no-args defaults to
+  current ns; also accepts quoted ns symbols, e.g. `(run-tests 'my.ns)`).
+  Per-namespace fixtures, counter isolation per `run-tests` call, `^:async`
+  test support, and `(async done body)` form for tests that resolve when
+  `done` is called. Runtime ships at `squint-cljs/src/squint/test.mjs`.
 - `with-meta` now preserves callability when applied to a function (returns a
   forwarding wrapper instead of a plain object via `copy()`).
 - Fix [#783](https://github.com/squint-cljs/squint/issues/783): auto-load macros from `.cljc` files via `:require` (no need for `:require-macros`)

bb/tasks.clj

@@ -87,7 +87,7 @@
     (shell "node" "node_cli.js" "compile" src)
     (let [out (:out (shell {:out :string} "node" out-file))]
       (fs/delete out-file)
-      (assert (str/includes? out "Ran 9 tests containing 19 assertions") out)
+      (assert (str/includes? out "Ran 10 tests containing 20 assertions") out)
       (assert (str/includes? out "1 failures, 0 errors") out)
       ;; :begin-test-ns must fire for each ns visited by run-tests
       (assert (str/includes? out "Testing ns.a") out)

doc/cljs-test-todo.md

@@ -70,16 +70,26 @@ everyone uses, but it's overridable). Same idea as `report`.
 
 ## Coverage gaps — features that exist but are partial
 
-### 7. `:begin-test-ns` / `:end-test-ns` are never emitted
-We support the report types in `report`'s `case`, but `run-tests` never
+### 7. `:begin-test-ns` / `:end-test-ns` are never emitted ✅ DONE
+~~We support the report types in `report`'s `case`, but `run-tests` never
 fires them. Real `clojure.test` brackets each ns it processes with these
-events; reporters use them to group output.
+events; reporters use them to group output.~~
 
-### 8. No `(t/async done body)` form
-Real `cljs.test` async tests use `(async done (do ... (done)))`. We use
+Fixed: `run-vars-with-once-fixtures` now brackets each ns's tests with
+`:begin-test-ns` / `:end-test-ns` reports, so `(t/run-tests 'my.ns)`
+prints `Testing my.ns` like cljs.test. Anonymous (nil-ns) groups are
+skipped. Smoke tests assert the lines appear.
+
+### 8. No `(t/async done body)` form ✅ DONE
+~~Real `cljs.test` async tests use `(async done (do ... (done)))`. We use
 `^:async` on the deftest plus a Promise-returning body. Functionally
 equivalent but different surface — code copied from a CLJS project
-won't run.
+won't run.~~
+
+Added: `core-async` macro expands `(async done body)` to
+`(js/Promise. (fn [done] body))`. `test-var` already awaits any
+Promise-returning test fn, so no additional plumbing was needed —
+the `^:async` form keeps working too. Regression tests in both repos.
 
 ### 9. Test discovery is registration-based, not metadata-based
 `clojure.test/run-tests` walks `ns-publics` and filters by

src/squint/compiler_common.cljc

@@ -316,7 +316,7 @@
        alias))))
 
 (def ^:private builtin-test-macro-names
-  '#{deftest deftest- is testing are use-fixtures})
+  '#{deftest deftest- is testing are async use-fixtures})
 
 (defn builtin-refer-is-macro?
   "Returns true when a `:refer`'d symbol is known to be a compiler built-in

src/squint/internal/test.cljc

@@ -98,6 +98,14 @@
       :once `(clojure.test/set-once-fixtures! ~ns-name [~@fns])
       :each `(clojure.test/set-each-fixtures! ~ns-name [~@fns]))))
 
+(defn core-async [_&form _&env done & body]
+  ;; (async done body...) — common cljs.test idiom for async tests.
+  ;; Expands to a Promise constructor whose `resolve` is bound to `done`
+  ;; in the body's scope. The deftest body returns this Promise and
+  ;; test-var awaits it; no ^:async marker needed on the outer fn.
+  (assert (symbol? done) "first argument to async must be a symbol")
+  `(js/Promise. (fn [~done] ~@body)))
+
 (defn core-run-tests [_&form &env & args]
   ;; Match cljs.test: with no args, default to the compile-time current ns.
   ;; Quoted namespace symbols `'my.ns` get converted to plain strings at
@@ -123,5 +131,6 @@
    'is core-is
    'testing core-testing
    'are core-are
+   'async core-async
    'use-fixtures core-use-fixtures
    'run-tests core-run-tests})

test-resources/cljs_test_smoke.cljs

@@ -1,5 +1,5 @@
 (ns cljs-test-smoke
-  (:require [cljs.test :as t :refer [deftest is testing are]]))
+  (:require [cljs.test :as t :refer [deftest is testing are async]]))
 
 (deftest math-test
   (testing "basic math"
@@ -99,6 +99,16 @@
         (is (nil? (:begin-test-ns counters))
             "no bogus :begin-test-ns key added")))))
 
+(deftest async-done-form-test
+  ;; (async done ...) is the cljs.test idiom — body runs, done resolves
+  ;; the wrapping promise, test-var awaits it.
+  (async done
+    (js/setTimeout
+     (fn []
+       (is (= 42 (* 6 7)))
+       (done))
+     5)))
+
 (deftest run-tests-quoted-symbol-test
   (testing "(run-tests 'my.ns) macro converts quoted symbol to a string"
     (let [saved-env (t/get-current-env)]
@@ -119,6 +129,7 @@
   (t/test-var thrown-test)
   (t/test-var expected-failure-test)
   (js-await (t/test-var async-test))
+  (js-await (t/test-var async-done-form-test))
   (t/test-var per-ns-each-fixtures-test)
   (t/test-var per-ns-once-fixtures-test)
   (t/test-var run-tests-counter-isolation-test)