phpstan baseline

Author: sreichel

.phpstan.dist.baseline.neon

@@ -90,12 +90,6 @@ parameters:
 			count: 2
 			path: app/code/core/Mage/Adminhtml/Block/Api/Tab/Rolesedit.php
 
-		-
-			rawMessage: If condition is always true.
-			identifier: if.alwaysTrue
-			count: 1
-			path: app/code/core/Mage/Adminhtml/Block/Api/Tab/Rolesedit.php
-
 		-
 			rawMessage: 'Call to an undefined method Mage_Api_Model_Resource_Roles_User_Collection::setUserFilter().'
 			identifier: method.notFound
@@ -1146,12 +1140,6 @@ parameters:
 			count: 16
 			path: app/code/core/Mage/Adminhtml/controllers/Sales/Order/ShipmentController.php
 
-		-
-			rawMessage: Negated boolean expression is always false.
-			identifier: booleanNot.alwaysFalse
-			count: 1
-			path: app/code/core/Mage/Adminhtml/controllers/Sales/Order/ShipmentController.php
-
 		-
 			rawMessage: 'Parameter #2 $callback of function array_filter expects (callable(mixed): bool)|null, Closure(array|bool|float|int|resource|string|null, int=): int given.'
 			identifier: argument.type
@@ -1164,6 +1152,12 @@ parameters:
 			count: 4
 			path: app/code/core/Mage/Adminhtml/controllers/Sales/OrderController.php
 
+		-
+			rawMessage: Variable $order might not be defined.
+			identifier: variable.undefined
+			count: 1
+			path: app/code/core/Mage/Adminhtml/controllers/Sales/OrderController.php
+
 		-
 			rawMessage: Dead catch - Exception is never thrown in the try block.
 			identifier: catch.neverThrown
@@ -1332,12 +1326,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Api/Model/Roles.php
 
-		-
-			rawMessage: 'Call to an undefined method Mage_Api_Model_Resource_Rules::update().'
-			identifier: method.notFound
-			count: 1
-			path: app/code/core/Mage/Api/Model/Rules.php
-
 		-
 			rawMessage: 'Construct empty() is not allowed. Use more strict comparison.'
 			identifier: empty.notAllowed
@@ -4632,12 +4620,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Dataflow/Model/Profile.php
 
-		-
-			rawMessage: Variable $fields might not be defined.
-			identifier: variable.undefined
-			count: 1
-			path: app/code/core/Mage/Dataflow/Model/Session/Parser/Csv.php
-
 		-
 			rawMessage: 'Construct empty() is not allowed. Use more strict comparison.'
 			identifier: empty.notAllowed
@@ -6567,7 +6549,7 @@ parameters:
 		-
 			rawMessage: 'Construct empty() is not allowed. Use more strict comparison.'
 			identifier: empty.notAllowed
-			count: 9
+			count: 6
 			path: app/code/core/Mage/Sales/Model/Order.php
 
 		-
@@ -6576,12 +6558,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Sales/Model/Order/Config.php
 
-		-
-			rawMessage: 'Construct empty() is not allowed. Use more strict comparison.'
-			identifier: empty.notAllowed
-			count: 1
-			path: app/code/core/Mage/Sales/Model/Order/Creditmemo.php
-
 		-
 			rawMessage: 'Construct empty() is not allowed. Use more strict comparison.'
 			identifier: empty.notAllowed
@@ -6597,7 +6573,7 @@ parameters:
 		-
 			rawMessage: 'Construct empty() is not allowed. Use more strict comparison.'
 			identifier: empty.notAllowed
-			count: 3
+			count: 1
 			path: app/code/core/Mage/Sales/Model/Order/Invoice.php
 
 		-
@@ -6672,12 +6648,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Sales/Model/Order/Pdf/Total/Default.php
 
-		-
-			rawMessage: 'Construct empty() is not allowed. Use more strict comparison.'
-			identifier: empty.notAllowed
-			count: 2
-			path: app/code/core/Mage/Sales/Model/Order/Shipment.php
-
 		-
 			rawMessage: 'Call to an undefined method Mage_Eav_Model_Entity_Abstract::getStoreId().'
 			identifier: method.notFound